Focus save button when entities save states panel is opened #30873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +71 B (0%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
david-szabo97
changed the title
david-szabo97
added
[Package] Editor
david-szabo97
requested review from
vindl,
jeyip,
mattwiebe,
Addison-Stavlo,
Copons,
creativecoder,
annezazu and
carolinan
Addison-Stavlo
approved these changes
Apr 15, 2021
carolinan
approved these changes
Apr 16, 2021
This was referenced Apr 18, 2021
talldan
added
the
Backport to WP Minor Release
|
@talldan, any reason for Backport label? This should already be in core based on the Gutenberg version. |
|
Not sure, it definitely doesn't need to be backported. Seems like I added the label accidentally. |
talldan
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29803
Description
Moves focus into the entities save states panel when it is opened via "Save" / "Publish" button. This change applies to both
post-editandsite-edit. Although this panel is only shown in the Post Editor when you make changes to other entities. (For example you edit a template part)How has this been tested?
Site Editor
Post Editor
Screenshots
Screen.Recording.2021-04-15.at.20.23.53.mov
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).