Template part block - fix PHP notice for placeholder block. #30928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addison-Stavlo
requested review from
vindl,
jeyip,
mattwiebe,
Copons,
creativecoder and
david-szabo97
Addison-Stavlo
added
[Block] Template Part
Addison-Stavlo
commented
Apr 16, 2021
Comment on lines
-22
to
-27
| if ( ! empty( $attributes['postId'] ) && get_post_status( $attributes['postId'] ) ) { | ||
| $template_part_id = $attributes['postId']; | ||
| // If we have a post ID and the post exists, which means this template part | ||
| // is user-customized, render the corresponding post content. | ||
| $content = get_post( $attributes['postId'] )->post_content; | ||
| } elseif ( |
There was a problem hiding this comment.
Note - removing this section is unrelated to the error noted in the PR description.
This code block is no longer necessary since postId has not been a valid attribute of the template part block for months now and content is always found via the slug/theme attributes.
|
Size Change: 0 B Total Size: 1.46 MB ℹ️ View Unchanged
|
carolinan
approved these changes
Apr 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we attempt to load a post containing a template part block placeholder block a php notice is present:
Or on the front-end:
This is because when no content for the template part is resolved, a message is printed to notify the user using
sprintfto attach theslugattribute of the template part to the message:Since a template part placeholder block has no
slugattribute, this also causessprintfto throw the php notice. However, we should not be showing this message if noslugattribute is present since absence of this attribute indicates a placeholder which by definition there should be no corresponding content found.In this PR we return nothing in the case of the placeholder, since no content is expected and no error message is required.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).