-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: CSS variable reference mechanism regression. #31015
Merged
jorgefilipecosta
merged 1 commit into
trunk
from
fix/fix-css-variable-reference-mechanism
Apr 20, 2021
Merged
Fix: CSS variable reference mechanism regression. #31015
jorgefilipecosta
merged 1 commit into
trunk
from
fix/fix-css-variable-reference-mechanism
Apr 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Regression
Related to a regression in the latest release
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
labels
Apr 20, 2021
Size Change: +2 B (0%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
[Type] Regression
Related to a regression in the latest release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shape of the global styles data structure passed by some changes and those changes caused a regression where the global styles CSS variable mechanism stopped working.
This PR fixes the regression.
Fixes: #28853
How has this been tested?
With TT1 Blocks theme trunk version active I opened the site editor and did the following steps: