[RNMobile] File and Audio block simplify media flow #31025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-alexander
added
the
Mobile App - i.e. Android or iOS
2 tasks
|
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
fluiddot
reviewed
Apr 21, 2021
fluiddot
reviewed
Apr 22, 2021
fluiddot
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
LGTM 🎊 !
I also tested the Image and Video blocks in case we introduced a regression in these changes and they work perfectly.
Tested on iPhone 11 (iOS 14.2) and Samsung Galaxy S20 FE 5G (Android 10).
NOTE: While testing I spotted a bug that is not related to these changes, I opened this issue as a follow-up.
Thanks for these efforts @fluiddot. I will check this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR wordpress-mobile/gutenberg-mobile#3399
Description
Adds the media options auto opening behavior to the File and Audio block that was implemented for the Image, Video, and Gallery Block
How has this been tested?
Manual Testing
E2E Testing
The auto-opening wasn't tested but the tests were modified to dismiss the picker when it opens. The changes follow the same pattern used in the previous PR. To test :
TEST_RN_PLATFORM=android/ios npm run native device-tests:local gutenberg-editor-file-@canary.testTEST_RN_PLATFORM=android/ios npm run native device-tests:local gutenberg-editor-audio.testRegression Testing
I noticed that the logic for the video and image block contained redundant logic within the
autoOpenMediaUploadprop. For both blocks, the media placeholder is not shown if any of the values ( src or url ) are undefined. 66acdbeScreenshots
File Block
Audio Block
Checklist:
*.native.jsfiles for terms that need renaming or removal).