Site logo: Add link toggle option #31162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +632 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Still learning about how to do the deprecation, and tests needs to be updated. |
|
Because there will be multiple changes to the site logo block, I think it makes more sense to do one update for tests and add the deprecated version after all changes have been made? |
|
I don't think there needs to be any kind of deprecation... This is an experimental block, and as such, breaking changes are to be expected. Once it gets included in core then I believe it will be marked as stable, but until then it's experimental, is it not? 🤔 |
|
For some reason I thought it was already in core 👍 |
carolinan
commented
Apr 29, 2021
carolinan
commented
Apr 29, 2021
aristath
approved these changes
Apr 29, 2021
aristath
reviewed
May 5, 2021
aristath
reviewed
May 5, 2021
aristath
reviewed
May 5, 2021
|
I would like to get this merged, but I am not sure that this is the best text for the option: "Make image a link to home". |
Co-authored-by: Ari Stathopoulos <aristath@gmail.com>
Co-authored-by: Ari Stathopoulos <aristath@gmail.com>
carolinan
commented
May 5, 2021
carolinan
commented
May 5, 2021
carolinan
commented
May 6, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial for #30406
Adds a link toggle and target option to the site logo block.
The current solution using
preg_replaceandstr_replacewould not be my first choice.I tried using https://developer.wordpress.org/reference/functions/wp_get_attachment_image/
and https://developer.wordpress.org/reference/hooks/wp_get_attachment_image_attributes/
to remove the link but I was not able to, because I could not make it work correctly with the size filter.
Because the link can not be changed, the rel is always the same, so I did not include that option.
How has this been tested?
Tested manually by adding 3 site logo blocks:
View the markup of the block in the editor and front.
Confirmed that links, link targets, and aria label are output correctly.
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).