Block editor: deprecate ObserveTyping and integrate it in the block editor #31280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
adamziel,
ajitbohra,
chrisvanpatten,
draganescu,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
|
Size Change: -18 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Apr 28, 2021
| /* 3. */ | ||
| <BlockList className="getdavesbe-block-editor__block-list" /> | ||
| </ObserveTyping> | ||
| <WritingFlow> /* 2. */ |
There was a problem hiding this comment.
Maybe! I've been thinking about this one and there's several things I'd like to change here. The focus capture element should ideally render outside the iframe as well.
youknowriad
reviewed
Apr 28, 2021
There was a problem hiding this comment.
There is one issue here and it's also something we'll have if/when we try to do the same for writing flow: Post title.
You can right now, start typing in the title and have the flag persisted when you move to blocks I think. It's probably more visible with writing flow. That Post Title not being a block has always been some kind of edge case, so I wonder if we should duplicate the behavior there instead but again, the PostTitle component can be rendered anywhere.
|
I'll check if it's an issue for the typing observer, but I thought it wouldn't since the title doesn't have a block toolbar. If it is, maybe we can add the hook there. |
|
Sure, typing in the title now doesn't set the |
annezazu
added
[Type] Code Quality
|
Done in #53875 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reduces the verbosity of implementing a block editor, but most of all for an iframed block editor that needs extra handlers on the iframe.
It also makes sense to build this in because the typing state is strongly tied to the block list.
The only reason I can think of to leave it outside the block list is to disable hiding the toolbar, but that doesn't make much sense if you have a floating toolbar, and in case of a fixed toolbar, tying wouldn't hide it anyway. If we do want to allow disabling it, we could add a block editor setting instead.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).