[Block Library - Query]: Add semantic wrapper element #31421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
ntsekouras
requested review from
mcsf,
aristath,
gziolo,
kjellr,
jasmussen,
carolinan and
Addison-Stavlo
|
Seems like a good start, and something we can always expand upon if need be. Though I can't think of any to add, unless we go into some details/summary shenanigans. Header/footer don't seem appropriate, do they? |
|
Size Change: -70 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
That's probably a good set? I'm sure someone's going to want to do something weird and have the Query be their footer, but they can file an issue if they find a good reason do do that. 😄 |
gziolo
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves: #28555
Sometimes, theme templates will consist of just a header template part, a footer template part, and a query loop in the middle. Semantically, that query should be wrapped in a
maintag. In other cases, the query should be wrapped in asectiontag.This PR adds the option in
Queryblock to change the wrapper element, underAdvancedinspector controls.Testing instructions
Advancedinspector controls in a Query block change the value ofHTML elementto a differenttag, save and see that the selection is applied in both editor and front-end.Notes
I have added only
div, main, section and asideas options. Should I add or remove something?--cc @kjellr @jasmussen @jameskoster