Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Block Library - Site Logo]: Return nothing if logo is not set #31513

Merged
merged 4 commits into from
May 6, 2021
Merged

[Block Library - Site Logo]: Return nothing if logo is not set #31513

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
815fa67
Return if no custom logo is set.
jffng May 5, 2021
65379fd
Comment the early return.
jffng May 5, 2021
5540188
Merge branch 'trunk' into fix/site-logo-render-cb
carolinan May 6, 2021
c23471c
Update packages/block-library/src/site-logo/index.php
ntsekouras May 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/block-library/src/site-logo/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,13 @@ function render_block_core_site_logo( $attributes ) {
};

add_filter( 'wp_get_attachment_image_src', $adjust_width_height_filter );

$custom_logo = get_custom_logo();
$classnames = array();
if ( empty( $custom_logo ) ) {
return '';
}

$classnames = array();
if ( ! empty( $attributes['className'] ) ) {
$classnames[] = $attributes['className'];
}
Expand Down