Performance: Factor out BlockMultiControls component from VisualEditorBlock #3172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
force-pushed
the
update/perf-multi-select-controls
branch
from
1fc94c9 to
488a891
Compare
Codecov Report
@@ Coverage Diff @@
## master #3172 +/- ##
==========================================
- Coverage 31.3% 31.25% -0.06%
==========================================
Files 246 247 +1
Lines 6762 6773 +11
Branches 1213 1214 +1
==========================================
Hits 2117 2117
- Misses 3909 3919 +10
- Partials 736 737 +1
Continue to review full report at Codecov.
|
aduth
force-pushed
the
update/perf-multi-select-controls
branch
from
488a891 to
a23bf91
Compare
mcsf
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #3171, #3170
This pull request seeks to optimize the rendering of individual blocks when selection occurs. Currently, any time a selection is made, including for a single block, the
multiSelectedBlockUidsprop changes for every block such that it incurs a render on all blocks. The changes here seek to factor out a separateBlockMultiControlscomponent which receives the changingmultiSelectedBlockUids, thereby preventing renders except in the block responsible for rendering the multi-selection block controls.Testing instructions:
Verify there are no regressions in the behavior of block multi-selection.