Fixes FSE Navigation sub-menu item styling regression #31754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdwijngaert
added
[Type] Regression
|
Size Change: +9 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
May 12, 2021
|
Thanks for the PR. I think this is a nice fix, especially because it's so small. But before you merge, I'm not sure it actually addresses the root cause. Why did it regress in the first place? Also, the black color is still there. Should it be? Here's before:
Note how there's a black color explicitly defined on the inner span. Here's after:
Now the black color is overridden by the newly added inherit rule. But why did it work before, what broke it, and where does the black come from? |
Is this maybe related to the G2 components being removed? |
|
This fix is probably fine to land if it needs to go into a point release. But we should probably figure out how it regressed, even if it needs a bisect. It feels weird to me that there's a black color explicitly defined on that inner component. |
|
Looks like it's still experimental and has only recently been introduced. If I do a quick search, the few locations it is being used have all defined a color property... Not sure what made it work in the past though. |
|
Alright I did a little digging, and #30661 is the last commit where the text had the right color:
The next one in the list is the one that regressed the color, that's #31291. Looking at that component, it has this value: from https://github.com/WordPress/gutenberg/pull/31291/files#diff-e4b73be6ec3057a00d7a0f3252abb299f13b34b45d7510ce75187887ac5cd1b4L12 — that's an unchanged value. But comparing the before and after, it looks like this Text component wasn't used inside the Button component in the previous iteration. So I guess there are two questions to answer here: should the Text component be used inside an "ItemUI" component? And also, should a Text component come pre-set with a black color, or should that color just always be inherited? |
|
Okay, let's do as you suggested. Use this change for the patch release, as we can be sure this does not impact anything else (or does it impact RN?). We can then get this looked at in a follow-up issue.
Not sure, I just assumed this was part of some kind of effort to convert all |
|
Fine to land this as a patch, yes, but I'd love to hear what's a good longer term fix that might also remove the bandaid if possible. CC: @gziolo @sarayourfriend in case you have answers to #31754 (comment). |
|
I do agree that it seems weird for me to enforce a color by default in the Text component. |
7 tasks
7 tasks
david-szabo97
approved these changes
May 14, 2021
|
Id think this makes sense as a patch fix. However, also agree the |
Copons
approved these changes
May 14, 2021
|
I'm merging this for now as a fix for the patch release, any volunteer for the follow-up for the Text component? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix the regression of the FSE Navigation sub-menu item styling as reported in #31574.
Closes #31574.
Screenshot:
Right now, it uses
inheritas color. Not sure about the text color before this issue, but it seems to be the right color now without adding more complexity, but that might not be the correct approach.My original suggestion was to move back to a
spanelement, but I'm not sure on plans for thatTextcomponent, so this might be a better solution.