Proof of concept: No in-canvas appender. #31886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +3 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
|
Yeah this feels infinitely better 🤩
I don't think it's too bad, even as it stands. The social links block is a more trying example due to the size, but even that is still quite easy to use imo:
We would need to figure out empty containers though:
|
|
I think empty containers are one of the few places where it makes sense to break the look-like-the-front-end rule. Usually, a container is meant to, well, contain something, so an empty one could almost always be considered to be in a sort of unfinished/placeholder state. There may be some blocks where this is not the case, but I can't think of any off the top of my head. Essentially, I figure that every empty container block should probably look similar to how an empty Group block looks, or else have some unique placeholder like the Navigation block. |
This was referenced Jun 1, 2021
7 tasks
This was referenced Sep 30, 2021
|
Since this one was only ever meant as an experiment (and can still be checked out even if closed, right?) — I'll close this one. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge this, it's purely a proof of concept. The goal of this is to explore alternatives to the current in-canvas appender — the black plus — which causes a big layout shift when appearing:
This PR simply forces that black plus to never be shown, eliminating that layout shift entirely:
This PR is not meant to be merged as is, it's only meant to explore a new baseline of no layout shift ever. In that vein, this is already wildly successful, especially in the site editor:
Here's before 🙈:
A few take-aways that are immediately evident: