Testing: Move config file for unit tests to its own subfolder #3203
Conversation
gziolo
added
Framework
| @@ -94,29 +94,28 @@ | |||
| "(blocks|components|date|editor|element|i18n|utils)/**/*.js" | |||
| ], | |||
| "coveragePathIgnorePatterns": [ | |||
| "<rootDir>/[^/]+/build/index.js", | |||
| ".*/story/[^/]+.js" | |||
There was a problem hiding this comment.
I can't see any /story/ subfolders inside folders which are scanned when generating code coverage. That's why removed this line.
There was a problem hiding this comment.
I imagine this is left-over from when we used React Storybook. Thinking the newer docutron directory should be similarly ignored.
There was a problem hiding this comment.
‘docutron’ folder is already ignored with the current setup, thanks for clarifying 👍
Codecov Report
@@ Coverage Diff @@
## master #3203 +/- ##
==========================================
+ Coverage 31.61% 33.61% +1.99%
==========================================
Files 221 221
Lines 6316 6842 +526
Branches 1122 1289 +167
==========================================
+ Hits 1997 2300 +303
- Misses 3631 3796 +165
- Partials 688 746 +58
Continue to review full report at Codecov.
|
| @@ -94,29 +94,28 @@ | |||
| "(blocks|components|date|editor|element|i18n|utils)/**/*.js" | |||
| ], | |||
| "coveragePathIgnorePatterns": [ | |||
| "<rootDir>/[^/]+/build/index.js", | |||
| ".*/story/[^/]+.js" | |||
There was a problem hiding this comment.
I imagine this is left-over from when we used React Storybook. Thinking the newer docutron directory should be similarly ignored.
Description
This PR moves configuration file to
test/unitsubfolder to sync with the upcoming changes in #3069 which introducestest/e2esubfolder for end-to-end testing solution.How Has This Been Tested?
Manually executed all test unit commands:
npm run test-unitnpm run test-unit:coveragenpm run test-unit:watchTravis should remain green.