Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Controller: Make test use test theme #32233

Closed
wants to merge 2 commits into from
Closed

Template Controller: Make test use test theme #32233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57f6e58
Block template theme fixture: Add header template
ockham May 26, 2021
4f70549
Template controller test: Use test theme rather than TT1 Blocks
ockham May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 38 additions & 20 deletions phpunit/class-gutenberg-rest-template-controller-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,15 @@ class Gutenberg_REST_Templates_Controller_Test extends WP_Test_REST_Controller_T
* @param WP_UnitTest_Factory $factory Helper that lets us create fake data.
*/
public static function wpSetupBeforeClass( $factory ) {
switch_theme( 'tt1-blocks' );
register_theme_directory( __DIR__ . '/fixtures/themes/' );

// Without this filter, get_template_directory() would erroneously return the default theme path
// (wp-content/themes/) for `test-theme` (rather than ./fixtures/themes/). Maybe a WP bug?
add_filter( 'template_directory', array( __CLASS__, 'change_theme_directory' ), 10, 2 );
add_filter( 'stylesheet_directory', array( __CLASS__, 'change_theme_directory' ), 10, 2 );

switch_theme( 'test-theme' );

gutenberg_register_template_post_type();
gutenberg_register_template_part_post_type();
gutenberg_register_wp_theme_taxonomy();
Expand All @@ -24,6 +32,15 @@ public static function wpSetupBeforeClass( $factory ) {
);
}

public static function wpTearDownAfterClass() {
remove_filter( 'stylesheet_directory', array( __CLASS__, 'change_theme_directory' ) );
remove_filter( 'template_directory', array( __CLASS__, 'change_theme_directory' ) );
}

static function change_theme_directory( $theme_dir, $theme ) {
return __DIR__ . '/fixtures/themes/' . $theme;
}

public function test_register_routes() {
$routes = rest_get_server()->get_routes();
$this->assertArrayHasKey( '/wp/v2/templates', $routes );
Expand Down Expand Up @@ -63,8 +80,8 @@ function find_and_normalize_template_by_id( $templates, $id ) {

$this->assertEquals(
array(
'id' => 'tt1-blocks//index',
'theme' => 'tt1-blocks',
'id' => 'test-theme//index',
'theme' => 'test-theme',
'slug' => 'index',
'title' => array(
'raw' => 'Index',
Expand All @@ -77,7 +94,7 @@ function find_and_normalize_template_by_id( $templates, $id ) {
'wp_id' => null,
'has_theme_file' => true,
),
find_and_normalize_template_by_id( $data, 'tt1-blocks//index' )
find_and_normalize_template_by_id( $data, 'test-theme//index' )
);

// Test template parts.
Expand All @@ -87,8 +104,8 @@ function find_and_normalize_template_by_id( $templates, $id ) {

$this->assertEquals(
array(
'id' => 'tt1-blocks//header',
'theme' => 'tt1-blocks',
'id' => 'test-theme//header',
'theme' => 'test-theme',
'slug' => 'header',
'title' => array(
'raw' => 'header',
Expand All @@ -102,22 +119,22 @@ function find_and_normalize_template_by_id( $templates, $id ) {
'area' => WP_TEMPLATE_PART_AREA_HEADER,
'has_theme_file' => true,
),
find_and_normalize_template_by_id( $data, 'tt1-blocks//header' )
find_and_normalize_template_by_id( $data, 'test-theme//header' )
);
}

public function test_get_item() {
wp_set_current_user( self::$admin_id );
$request = new WP_REST_Request( 'GET', '/wp/v2/templates/tt1-blocks//index' );
$request = new WP_REST_Request( 'GET', '/wp/v2/templates/test-theme//index' );
$response = rest_get_server()->dispatch( $request );
$data = $response->get_data();
unset( $data['content'] );
unset( $data['_links'] );

$this->assertEquals(
array(
'id' => 'tt1-blocks//index',
'theme' => 'tt1-blocks',
'id' => 'test-theme//index',
'theme' => 'test-theme',
'slug' => 'index',
'title' => array(
'raw' => 'Index',
Expand All @@ -134,15 +151,15 @@ public function test_get_item() {
);

// Test template parts.
$request = new WP_REST_Request( 'GET', '/wp/v2/template-parts/tt1-blocks//header' );
$request = new WP_REST_Request( 'GET', '/wp/v2/template-parts/test-theme//header' );
$response = rest_get_server()->dispatch( $request );
$data = $response->get_data();
unset( $data['content'] );
unset( $data['_links'] );
$this->assertEquals(
array(
'id' => 'tt1-blocks//header',
'theme' => 'tt1-blocks',
'id' => 'test-theme//header',
'theme' => 'test-theme',
'slug' => 'header',
'title' => array(
'raw' => 'header',
Expand Down Expand Up @@ -178,8 +195,8 @@ public function test_create_item() {

$this->assertEquals(
array(
'id' => 'tt1-blocks//my_custom_template',
'theme' => 'tt1-blocks',
'id' => 'test-theme//my_custom_template',
'theme' => 'test-theme',
'slug' => 'my_custom_template',
'title' => array(
'raw' => 'My Template',
Expand Down Expand Up @@ -215,8 +232,8 @@ public function test_create_item() {

$this->assertEquals(
array(
'id' => 'tt1-blocks//my_custom_template_part',
'theme' => 'tt1-blocks',
'id' => 'test-theme//my_custom_template_part',
'theme' => 'test-theme',
'slug' => 'my_custom_template_part',
'title' => array(
'raw' => 'My Template Part',
Expand All @@ -238,7 +255,7 @@ public function test_create_item() {

public function test_update_item() {
wp_set_current_user( self::$admin_id );
$request = new WP_REST_Request( 'PUT', '/wp/v2/templates/tt1-blocks//index' );
$request = new WP_REST_Request( 'PUT', '/wp/v2/templates/test-theme//index' );
$request->set_body_params(
array(
'title' => 'My new Index Title',
Expand All @@ -250,7 +267,7 @@ public function test_update_item() {
$this->assertEquals( 'custom', $data['source'] );

// Test template parts.
$request = new WP_REST_Request( 'PUT', '/wp/v2/template-parts/tt1-blocks//header' );
$request = new WP_REST_Request( 'PUT', '/wp/v2/template-parts/test-theme//header' );
$request->set_body_params(
array(
'area' => 'something unsupported',
Expand All @@ -268,8 +285,9 @@ public function test_delete_item() {
$response = rest_get_server()->dispatch( $request );
$this->assertErrorResponse( 'rest_template_not_found', $response, 404 );

// Cannot delete a file-based template.
wp_set_current_user( self::$admin_id );
$request = new WP_REST_Request( 'DELETE', '/wp/v2/templates/tt1-blocks//single' );
$request = new WP_REST_Request( 'DELETE', '/wp/v2/templates/test-theme//page' );
$response = rest_get_server()->dispatch( $request );
$this->assertErrorResponse( 'rest_invalid_template', $response, 400 );
}
Expand Down
3 changes: 3 additions & 0 deletions phpunit/fixtures/themes/test-theme/block-template-parts/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<!-- wp:paragraph -->
<p>Header Template Part</p>
<!-- /wp:paragraph -->
8 changes: 8 additions & 0 deletions phpunit/fixtures/themes/test-theme/experimental-theme.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"templateParts": [
{
"name": "header",
"area": "header"
}
]
}