Image Block: Correctly set image size slug #32364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Block] Image
|
Size Change: +92 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
|
Thank you George for fixing this bug! Before: Applying a GB special build of the plugin. PR works as mentioned. |
paaljoachim
added
the
Backport to WP 6.7 Beta/RC
|
As this is a bug fix. I assume it can be backported to WP 5.8. I went ahead and added the Backport label. |
|
@gwwar Kerry can you take a look at this PR? |
gwwar
reviewed
Jun 21, 2021
There was a problem hiding this comment.
🤔 Is there anything else I need to do to make the named image size options appear? I don't see the drop down using 2021 or Armando theme.
Provided that "full" is a good fallback and supported by all themes, I think the code here looks reasonable.
One non-blocking note is that optional chaining could make sense here. This might look like:
const fallbackSize = 'full';
const imageUrl = image?.sizes?.defaultSize?.url;
const sourceUrl = image?.media_details?.sizes?.defaultSize?.source_url;
const sizeSlug = ( imageUrl || sourceUrl ) ?? fallbackSize;
|
Thanks for testing, @gwwar Are image sizes available in block editor? wp.data.select('core/block-editor').getSettings().imageSizes;I've also seen this happen if there're no image sizes generated for media. Usually, when the image is smaller than a thumbnail. See: gutenberg/packages/block-library/src/image/image.js Lines 162 to 167 in c9950a3 |
gwwar
approved these changes
Jun 23, 2021
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When default image size isn't available for uploaded media, the Image block uses a full-size image. But
sizeSlugis still set for default. This causes incorrect image size selection inImageSizeControlcomponent.PR adds logic to fallback to 'full' size when default image size isn't available.
Fixes #27198.
How has this been tested?
Settings -> Media. 1024x1024px by default.Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).