Edit Post: Prevent locking users in saving state when saving meta boxes fails #32485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Package] Edit Post
|
Size Change: +6 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Jun 7, 2021
Mamaduka
force-pushed
the
fix/metabox-api-fetch-failures
branch
from
46bdafa to
a6410ee
Compare
|
Thanks for the review, @tyxla
I was thinking the same while working on PR. But since we don't currently have a different state for failed meta box saving, all the new So decided to keep it simple for now. Happy to change the logic if there's a need for a separated |
Mamaduka
force-pushed
the
fix/metabox-api-fetch-failures
branch
from
a6410ee to
3d97884
Compare
|
Thanks for the fix!
Maybe we could expand the semantics in the reducer: export function isSavingMetaBoxes( state = false, action ) {
switch ( action.type ) {
case 'REQUEST_META_BOX_UPDATES':
return true;
case 'META_BOX_UPDATES_SUCCESS':
+ case 'META_BOX_UPDATES_FAILURE':
return false;
default:
return state;
}
}And adjust the error handling accordingly: try {
yield apiFetch( ... ); // Save the metaboxes
yield controls.dispatch( editPostStore.name, 'metaBoxUpdatesSuccess' );
} catch ( e ) {
e; // Maybe inspect the error
yield controls.dispatch( editPostStore.name, 'metaBoxUpdatesFailure' );
}cc @youknowriad |
|
Thanks for the feedback, @mcsf. I can create a new PR for the update. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes logic to update the
isSavingMetaBoxesstate even if the saving meta boxes request fails.Fixes #6966.
Fixes #19780.
How has this been tested?
.maintenancefile in the WP root directory, with contents:Screenshots
CleanShot.2021-06-07.at.17.19.41.mp4
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).