Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct wrong setState call #32808

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Correct wrong setState call #32808

merged 1 commit into from
Jul 6, 2021

Conversation

Luke1982
Copy link
Contributor

setState was called with only the value, not the key/value pair as an object

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

setState was called with only the value, not the key/value pair as an object
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Luke1982! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 18, 2021
@youknowriad
Copy link
Contributor

Hi there! thanks for the PR. I think right now withState is deprecated so can we update the doc to use useState instead?

@talldan talldan added the [Type] Developer Documentation Documentation for developers label Jun 22, 2021
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve and merge changes since there has been no activity for some time, and the changes are correct.

I started working on replacing withState with the useState hook. The first part can be found here #33173. I will handle additional changes requested in the upcoming PR.

@Mamaduka Mamaduka merged commit de3b53f into WordPress:trunk Jul 6, 2021
@github-actions
Copy link

github-actions bot commented Jul 6, 2021

Congratulations on your first merged pull request, @Luke1982! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 11.1 milestone Jul 6, 2021
sarayourfriend pushed a commit that referenced this pull request Jul 15, 2021
The `setState` was called with only the value, not the key/value pair as an object.
@jeffpaul
Copy link
Member

@Luke1982 pinging you again to see if you can help confirm your WordPress.org username so you can be properly credited in the WordPress 5.9 release? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants