Allow left/right/center alignments when a layout is defined #32810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
scruffian,
kjellr,
jasmussen,
MaggieCabrera and
carolinan
|
Size Change: +11 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
kjellr
approved these changes
Jun 18, 2021
There was a problem hiding this comment.
This works well in my testing. As noted, left/right alignments will expand outside of the text column by default:
I think that's a totally fine treatment, but if that's not what you want, it can be easily remedied by grouping content:
In general, this feels like a good solution to me, and gives users more flexibility. 👍
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
added a commit
that referenced
this pull request
Jun 21, 2021
youknowriad
added a commit
that referenced
this pull request
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #30568
When we introduced the layout config, we made the decision to remove left/right alignments from containers with a defined layout, the idea was that we can't left/right align inside the "content size" area, so to avoid confusing users, we shouldn't propose these options.
Apparently, removing these is even more confusing and some themes do expect float alignments to work like that (left/right align at the edge of the container), so we're bringing these in this PR
Testing instructions
Please help test this with several themes. It requires a theme with theme.json though.