-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix legacy widget edit style bleed #32871
Conversation
Size Change: +309 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
@@ -21,6 +21,10 @@ | |||
.block-list-appender.wp-block { | |||
width: initial; | |||
} | |||
// Override theme custom widths for blocks. | |||
.editor-styles-wrapper .wp-block.wp-block.wp-block.wp-block.wp-block { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just do !important
here, or would that be too much specificity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I prefer to go with the lowest specificity option where possible - this should be enough, and it it proves not to be we can always change it to !important
later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dd0e1be
to
fcdaa40
Compare
Oooh good catch! I've pushed a fix. I have also been able to reproduce the dark inserter. When a dark background is set on the theme but dark mode is NOT enabled, the |
Ugh, I'd added the wrong classname 🤦 Should all be fixed now! |
* Fix legacy widget edit style bleed * Match block width with inserter. * Make sure all text in legacy widget placeholders is legible. * Fix background color issue.
* Fix legacy widget edit style bleed * Match block width with inserter. * Make sure all text in legacy widget placeholders is legible. * Fix background color issue.
Description
Fixes #32849.
Legacy widget edit forms were inheriting some theme styles, this PR adds some CSS to override them.
How has this been tested?
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.js
files for terms that need renaming or removal).