Fix wide widget styles to allow floated contents. #32976

tellthemachines · 2021-06-25T05:17:37Z

Description

When legacy widgets contain floated elements, they shouldn't overflow the container. Also sets a min-width for the Customizer wide widget popover.

How has this been tested?

See testing instructions on both issues.

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

My code is tested.
My code follows the WordPress code style.
My code follows the accessibility standards.
I've tested my changes with keyboard and screen readers.
My code has proper inline documentation.
I've included developer documentation if appropriate.
I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

github-actions · 2021-06-25T05:24:10Z

Size Change: +59 B (0%)

Total Size: 1.04 MB

Filename	Size	Change
`build/widgets/style-rtl.css`	890 B	+30 B (+3%)
`build/widgets/style.css`	890 B	+29 B (+3%)

ℹ️ View Unchanged

Filename	Size
`build/a11y/index.min.js`	1.12 kB
`build/annotations/index.min.js`	2.93 kB
`build/api-fetch/index.min.js`	2.44 kB
`build/autop/index.min.js`	2.28 kB
`build/blob/index.min.js`	672 B
`build/block-directory/index.min.js`	6.62 kB
`build/block-directory/style-rtl.css`	989 B
`build/block-directory/style.css`	990 B
`build/block-editor/index.min.js`	119 kB
`build/block-editor/style-rtl.css`	13.5 kB
`build/block-editor/style.css`	13.5 kB
`build/block-library/blocks/archives/editor-rtl.css`	61 B
`build/block-library/blocks/archives/editor.css`	60 B
`build/block-library/blocks/archives/style-rtl.css`	65 B
`build/block-library/blocks/archives/style.css`	65 B
`build/block-library/blocks/audio/editor-rtl.css`	58 B
`build/block-library/blocks/audio/editor.css`	58 B
`build/block-library/blocks/audio/style-rtl.css`	112 B
`build/block-library/blocks/audio/style.css`	112 B
`build/block-library/blocks/audio/theme-rtl.css`	125 B
`build/block-library/blocks/audio/theme.css`	125 B
`build/block-library/blocks/block/editor-rtl.css`	161 B
`build/block-library/blocks/block/editor.css`	161 B
`build/block-library/blocks/button/editor-rtl.css`	475 B
`build/block-library/blocks/button/editor.css`	474 B
`build/block-library/blocks/button/style-rtl.css`	603 B
`build/block-library/blocks/button/style.css`	602 B
`build/block-library/blocks/buttons/editor-rtl.css`	315 B
`build/block-library/blocks/buttons/editor.css`	315 B
`build/block-library/blocks/buttons/style-rtl.css`	375 B
`build/block-library/blocks/buttons/style.css`	375 B
`build/block-library/blocks/calendar/style-rtl.css`	208 B
`build/block-library/blocks/calendar/style.css`	208 B
`build/block-library/blocks/categories/editor-rtl.css`	84 B
`build/block-library/blocks/categories/editor.css`	83 B
`build/block-library/blocks/categories/style-rtl.css`	79 B
`build/block-library/blocks/categories/style.css`	79 B
`build/block-library/blocks/code/style-rtl.css`	90 B
`build/block-library/blocks/code/style.css`	90 B
`build/block-library/blocks/code/theme-rtl.css`	131 B
`build/block-library/blocks/code/theme.css`	131 B
`build/block-library/blocks/columns/editor-rtl.css`	190 B
`build/block-library/blocks/columns/editor.css`	190 B
`build/block-library/blocks/columns/style-rtl.css`	422 B
`build/block-library/blocks/columns/style.css`	422 B
`build/block-library/blocks/cover/editor-rtl.css`	670 B
`build/block-library/blocks/cover/editor.css`	670 B
`build/block-library/blocks/cover/style-rtl.css`	1.22 kB
`build/block-library/blocks/cover/style.css`	1.23 kB
`build/block-library/blocks/embed/editor-rtl.css`	486 B
`build/block-library/blocks/embed/editor.css`	486 B
`build/block-library/blocks/embed/style-rtl.css`	401 B
`build/block-library/blocks/embed/style.css`	400 B
`build/block-library/blocks/embed/theme-rtl.css`	124 B
`build/block-library/blocks/embed/theme.css`	124 B
`build/block-library/blocks/file/editor-rtl.css`	301 B
`build/block-library/blocks/file/editor.css`	300 B
`build/block-library/blocks/file/style-rtl.css`	255 B
`build/block-library/blocks/file/style.css`	255 B
`build/block-library/blocks/file/view.min.js`	780 B
`build/block-library/blocks/freeform/editor-rtl.css`	2.44 kB
`build/block-library/blocks/freeform/editor.css`	2.44 kB
`build/block-library/blocks/gallery/editor-rtl.css`	704 B
`build/block-library/blocks/gallery/editor.css`	705 B
`build/block-library/blocks/gallery/style-rtl.css`	1.06 kB
`build/block-library/blocks/gallery/style.css`	1.06 kB
`build/block-library/blocks/gallery/theme-rtl.css`	122 B
`build/block-library/blocks/gallery/theme.css`	122 B
`build/block-library/blocks/group/editor-rtl.css`	160 B
`build/block-library/blocks/group/editor.css`	160 B
`build/block-library/blocks/group/style-rtl.css`	57 B
`build/block-library/blocks/group/style.css`	57 B
`build/block-library/blocks/group/theme-rtl.css`	93 B
`build/block-library/blocks/group/theme.css`	93 B
`build/block-library/blocks/heading/editor-rtl.css`	152 B
`build/block-library/blocks/heading/editor.css`	152 B
`build/block-library/blocks/heading/style-rtl.css`	76 B
`build/block-library/blocks/heading/style.css`	76 B
`build/block-library/blocks/home-link/style-rtl.css`	259 B
`build/block-library/blocks/home-link/style.css`	259 B
`build/block-library/blocks/html/editor-rtl.css`	281 B
`build/block-library/blocks/html/editor.css`	281 B
`build/block-library/blocks/image/editor-rtl.css`	729 B
`build/block-library/blocks/image/editor.css`	727 B
`build/block-library/blocks/image/style-rtl.css`	481 B
`build/block-library/blocks/image/style.css`	485 B
`build/block-library/blocks/image/theme-rtl.css`	124 B
`build/block-library/blocks/image/theme.css`	124 B
`build/block-library/blocks/latest-comments/style-rtl.css`	281 B
`build/block-library/blocks/latest-comments/style.css`	282 B
`build/block-library/blocks/latest-posts/editor-rtl.css`	137 B
`build/block-library/blocks/latest-posts/editor.css`	137 B
`build/block-library/blocks/latest-posts/style-rtl.css`	529 B
`build/block-library/blocks/latest-posts/style.css`	529 B
`build/block-library/blocks/list/style-rtl.css`	63 B
`build/block-library/blocks/list/style.css`	63 B
`build/block-library/blocks/media-text/editor-rtl.css`	263 B
`build/block-library/blocks/media-text/editor.css`	264 B
`build/block-library/blocks/media-text/style-rtl.css`	492 B
`build/block-library/blocks/media-text/style.css`	489 B
`build/block-library/blocks/more/editor-rtl.css`	434 B
`build/block-library/blocks/more/editor.css`	434 B
`build/block-library/blocks/navigation-link/editor-rtl.css`	633 B
`build/block-library/blocks/navigation-link/editor.css`	634 B
`build/block-library/blocks/navigation-link/style-rtl.css`	94 B
`build/block-library/blocks/navigation-link/style.css`	94 B
`build/block-library/blocks/navigation/editor-rtl.css`	1.55 kB
`build/block-library/blocks/navigation/editor.css`	1.55 kB
`build/block-library/blocks/navigation/style-rtl.css`	1.63 kB
`build/block-library/blocks/navigation/style.css`	1.63 kB
`build/block-library/blocks/navigation/view.min.js`	2.87 kB
`build/block-library/blocks/nextpage/editor-rtl.css`	395 B
`build/block-library/blocks/nextpage/editor.css`	395 B
`build/block-library/blocks/page-list/editor-rtl.css`	310 B
`build/block-library/blocks/page-list/editor.css`	311 B
`build/block-library/blocks/page-list/style-rtl.css`	240 B
`build/block-library/blocks/page-list/style.css`	240 B
`build/block-library/blocks/paragraph/editor-rtl.css`	157 B
`build/block-library/blocks/paragraph/editor.css`	157 B
`build/block-library/blocks/paragraph/style-rtl.css`	247 B
`build/block-library/blocks/paragraph/style.css`	248 B
`build/block-library/blocks/post-author/editor-rtl.css`	209 B
`build/block-library/blocks/post-author/editor.css`	209 B
`build/block-library/blocks/post-author/style-rtl.css`	183 B
`build/block-library/blocks/post-author/style.css`	184 B
`build/block-library/blocks/post-comments-form/style-rtl.css`	140 B
`build/block-library/blocks/post-comments-form/style.css`	140 B
`build/block-library/blocks/post-comments/style-rtl.css`	360 B
`build/block-library/blocks/post-comments/style.css`	359 B
`build/block-library/blocks/post-content/editor-rtl.css`	139 B
`build/block-library/blocks/post-content/editor.css`	139 B
`build/block-library/blocks/post-excerpt/editor-rtl.css`	73 B
`build/block-library/blocks/post-excerpt/editor.css`	73 B
`build/block-library/blocks/post-excerpt/style-rtl.css`	69 B
`build/block-library/blocks/post-excerpt/style.css`	69 B
`build/block-library/blocks/post-featured-image/editor-rtl.css`	338 B
`build/block-library/blocks/post-featured-image/editor.css`	338 B
`build/block-library/blocks/post-featured-image/style-rtl.css`	141 B
`build/block-library/blocks/post-featured-image/style.css`	141 B
`build/block-library/blocks/post-template/editor-rtl.css`	100 B
`build/block-library/blocks/post-template/editor.css`	99 B
`build/block-library/blocks/post-template/style-rtl.css`	379 B
`build/block-library/blocks/post-template/style.css`	380 B
`build/block-library/blocks/post-title/style-rtl.css`	60 B
`build/block-library/blocks/post-title/style.css`	60 B
`build/block-library/blocks/preformatted/style-rtl.css`	103 B
`build/block-library/blocks/preformatted/style.css`	103 B
`build/block-library/blocks/pullquote/editor-rtl.css`	183 B
`build/block-library/blocks/pullquote/editor.css`	183 B
`build/block-library/blocks/pullquote/style-rtl.css`	318 B
`build/block-library/blocks/pullquote/style.css`	318 B
`build/block-library/blocks/pullquote/theme-rtl.css`	169 B
`build/block-library/blocks/pullquote/theme.css`	169 B
`build/block-library/blocks/query-pagination-numbers/editor-rtl.css`	122 B
`build/block-library/blocks/query-pagination-numbers/editor.css`	121 B
`build/block-library/blocks/query-pagination/editor-rtl.css`	270 B
`build/block-library/blocks/query-pagination/editor.css`	262 B
`build/block-library/blocks/query-pagination/style-rtl.css`	168 B
`build/block-library/blocks/query-pagination/style.css`	168 B
`build/block-library/blocks/query-title/editor-rtl.css`	86 B
`build/block-library/blocks/query-title/editor.css`	86 B
`build/block-library/blocks/query/editor-rtl.css`	131 B
`build/block-library/blocks/query/editor.css`	132 B
`build/block-library/blocks/quote/style-rtl.css`	169 B
`build/block-library/blocks/quote/style.css`	169 B
`build/block-library/blocks/quote/theme-rtl.css`	221 B
`build/block-library/blocks/quote/theme.css`	221 B
`build/block-library/blocks/rss/editor-rtl.css`	201 B
`build/block-library/blocks/rss/editor.css`	202 B
`build/block-library/blocks/rss/style-rtl.css`	290 B
`build/block-library/blocks/rss/style.css`	290 B
`build/block-library/blocks/search/editor-rtl.css`	211 B
`build/block-library/blocks/search/editor.css`	211 B
`build/block-library/blocks/search/style-rtl.css`	359 B
`build/block-library/blocks/search/style.css`	362 B
`build/block-library/blocks/search/theme-rtl.css`	64 B
`build/block-library/blocks/search/theme.css`	64 B
`build/block-library/blocks/separator/editor-rtl.css`	99 B
`build/block-library/blocks/separator/editor.css`	99 B
`build/block-library/blocks/separator/style-rtl.css`	251 B
`build/block-library/blocks/separator/style.css`	251 B
`build/block-library/blocks/separator/theme-rtl.css`	172 B
`build/block-library/blocks/separator/theme.css`	172 B
`build/block-library/blocks/shortcode/editor-rtl.css`	512 B
`build/block-library/blocks/shortcode/editor.css`	512 B
`build/block-library/blocks/site-logo/editor-rtl.css`	440 B
`build/block-library/blocks/site-logo/editor.css`	441 B
`build/block-library/blocks/site-logo/style-rtl.css`	154 B
`build/block-library/blocks/site-logo/style.css`	154 B
`build/block-library/blocks/site-tagline/editor-rtl.css`	87 B
`build/block-library/blocks/site-tagline/editor.css`	87 B
`build/block-library/blocks/site-title/editor-rtl.css`	85 B
`build/block-library/blocks/site-title/editor.css`	85 B
`build/block-library/blocks/social-link/editor-rtl.css`	164 B
`build/block-library/blocks/social-link/editor.css`	165 B
`build/block-library/blocks/social-links/editor-rtl.css`	800 B
`build/block-library/blocks/social-links/editor.css`	799 B
`build/block-library/blocks/social-links/style-rtl.css`	1.34 kB
`build/block-library/blocks/social-links/style.css`	1.34 kB
`build/block-library/blocks/spacer/editor-rtl.css`	308 B
`build/block-library/blocks/spacer/editor.css`	308 B
`build/block-library/blocks/spacer/style-rtl.css`	48 B
`build/block-library/blocks/spacer/style.css`	48 B
`build/block-library/blocks/table/editor-rtl.css`	478 B
`build/block-library/blocks/table/editor.css`	478 B
`build/block-library/blocks/table/style-rtl.css`	480 B
`build/block-library/blocks/table/style.css`	480 B
`build/block-library/blocks/table/theme-rtl.css`	188 B
`build/block-library/blocks/table/theme.css`	188 B
`build/block-library/blocks/tag-cloud/editor-rtl.css`	118 B
`build/block-library/blocks/tag-cloud/editor.css`	118 B
`build/block-library/blocks/tag-cloud/style-rtl.css`	94 B
`build/block-library/blocks/tag-cloud/style.css`	94 B
`build/block-library/blocks/template-part/editor-rtl.css`	551 B
`build/block-library/blocks/template-part/editor.css`	550 B
`build/block-library/blocks/template-part/theme-rtl.css`	101 B
`build/block-library/blocks/template-part/theme.css`	101 B
`build/block-library/blocks/term-description/editor-rtl.css`	90 B
`build/block-library/blocks/term-description/editor.css`	90 B
`build/block-library/blocks/text-columns/editor-rtl.css`	95 B
`build/block-library/blocks/text-columns/editor.css`	95 B
`build/block-library/blocks/text-columns/style-rtl.css`	166 B
`build/block-library/blocks/text-columns/style.css`	166 B
`build/block-library/blocks/verse/style-rtl.css`	87 B
`build/block-library/blocks/verse/style.css`	87 B
`build/block-library/blocks/video/editor-rtl.css`	569 B
`build/block-library/blocks/video/editor.css`	570 B
`build/block-library/blocks/video/style-rtl.css`	173 B
`build/block-library/blocks/video/style.css`	173 B
`build/block-library/blocks/video/theme-rtl.css`	124 B
`build/block-library/blocks/video/theme.css`	124 B
`build/block-library/common-rtl.css`	1.26 kB
`build/block-library/common.css`	1.26 kB
`build/block-library/editor-rtl.css`	9.72 kB
`build/block-library/editor.css`	9.72 kB
`build/block-library/index.min.js`	145 kB
`build/block-library/reset-rtl.css`	514 B
`build/block-library/reset.css`	515 B
`build/block-library/style-rtl.css`	10.2 kB
`build/block-library/style.css`	10.2 kB
`build/block-library/theme-rtl.css`	692 B
`build/block-library/theme.css`	693 B
`build/block-serialization-default-parser/index.min.js`	1.29 kB
`build/block-serialization-spec-parser/index.min.js`	3.06 kB
`build/blocks/index.min.js`	47.3 kB
`build/components/index.min.js`	182 kB
`build/components/style-rtl.css`	16.2 kB
`build/components/style.css`	16.2 kB
`build/compose/index.min.js`	10.2 kB
`build/core-data/index.min.js`	12.2 kB
`build/customize-widgets/index.min.js`	10 kB
`build/customize-widgets/style-rtl.css`	1.46 kB
`build/customize-widgets/style.css`	1.45 kB
`build/data-controls/index.min.js`	828 B
`build/data/index.min.js`	7.23 kB
`build/date/index.min.js`	31.8 kB
`build/deprecated/index.min.js`	738 B
`build/dom-ready/index.min.js`	577 B
`build/dom/index.min.js`	4.62 kB
`build/edit-navigation/index.min.js`	14 kB
`build/edit-navigation/style-rtl.css`	3.09 kB
`build/edit-navigation/style.css`	3.09 kB
`build/edit-post/classic-rtl.css`	454 B
`build/edit-post/classic.css`	454 B
`build/edit-post/index.min.js`	58.7 kB
`build/edit-post/style-rtl.css`	7.04 kB
`build/edit-post/style.css`	7.03 kB
`build/edit-site/index.min.js`	26 kB
`build/edit-site/style-rtl.css`	4.76 kB
`build/edit-site/style.css`	4.75 kB
`build/edit-widgets/index.min.js`	16.1 kB
`build/edit-widgets/style-rtl.css`	3.57 kB
`build/edit-widgets/style.css`	3.57 kB
`build/editor/index.min.js`	38.6 kB
`build/editor/style-rtl.css`	3.91 kB
`build/editor/style.css`	3.9 kB
`build/element/index.min.js`	3.44 kB
`build/escape-html/index.min.js`	739 B
`build/format-library/index.min.js`	5.68 kB
`build/format-library/style-rtl.css`	637 B
`build/format-library/style.css`	639 B
`build/hooks/index.min.js`	1.76 kB
`build/html-entities/index.min.js`	628 B
`build/i18n/index.min.js`	3.73 kB
`build/is-shallow-equal/index.min.js`	710 B
`build/keyboard-shortcuts/index.min.js`	1.74 kB
`build/keycodes/index.min.js`	1.43 kB
`build/list-reusable-blocks/index.min.js`	2.07 kB
`build/list-reusable-blocks/style-rtl.css`	629 B
`build/list-reusable-blocks/style.css`	628 B
`build/media-utils/index.min.js`	3.08 kB
`build/notices/index.min.js`	1.07 kB
`build/nux/index.min.js`	2.31 kB
`build/nux/style-rtl.css`	718 B
`build/nux/style.css`	716 B
`build/plugins/index.min.js`	1.99 kB
`build/primitives/index.min.js`	1.03 kB
`build/priority-queue/index.min.js`	791 B
`build/react-i18n/index.min.js`	924 B
`build/redux-routine/index.min.js`	2.82 kB
`build/reusable-blocks/index.min.js`	2.56 kB
`build/reusable-blocks/style-rtl.css`	225 B
`build/reusable-blocks/style.css`	225 B
`build/rich-text/index.min.js`	10.6 kB
`build/server-side-render/index.min.js`	1.63 kB
`build/shortcode/index.min.js`	1.68 kB
`build/token-list/index.min.js`	848 B
`build/url/index.min.js`	1.95 kB
`build/viewport/index.min.js`	1.28 kB
`build/warning/index.min.js`	1.13 kB
`build/widgets/index.min.js`	6.21 kB
`build/wordcount/index.min.js`	1.24 kB

_{compressed-size-action}

talldan

Works well 🚢

Fix wide widget styles to allow floated contents.

42910eb

tellthemachines linked an issue Jun 25, 2021 that may be closed by this pull request

Widget editor: In customizer, wide, tall widgets display poorly #32973

Closed

tellthemachines added [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Type] Bug An existing feature does not function as intended labels Jun 25, 2021

talldan approved these changes Jun 25, 2021

View reviewed changes

talldan merged commit 81223fe into trunk Jun 25, 2021

talldan deleted the fix/wide-widgets-styles branch June 25, 2021 07:04

github-actions bot added this to the Gutenberg 11.0 milestone Jun 25, 2021

talldan added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 25, 2021

youknowriad removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 25, 2021

youknowriad pushed a commit that referenced this pull request Jun 25, 2021

Fix wide widget styles to allow floated contents. (#32976)

a8c4909

youknowriad mentioned this pull request Jun 25, 2021

More fixes and backports for WP 5.8 beta 4 #32992

Merged

youknowriad pushed a commit that referenced this pull request Jun 25, 2021

Fix wide widget styles to allow floated contents. (#32976)

23db24d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix wide widget styles to allow floated contents. #32976

Fix wide widget styles to allow floated contents. #32976

tellthemachines commented Jun 25, 2021

github-actions bot commented Jun 25, 2021

talldan left a comment

Fix wide widget styles to allow floated contents. #32976

Fix wide widget styles to allow floated contents. #32976

Conversation

tellthemachines commented Jun 25, 2021

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

github-actions bot commented Jun 25, 2021

talldan left a comment

Choose a reason for hiding this comment