-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
components: Remove @emotion/css
from ZStack
#33053
Conversation
@emotion/css
from ZStack@emotion/css
from ZStack
69b41d2
to
32e1689
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@@ -20,9 +16,7 @@ import { getValidChildren } from '../ui/utils/get-valid-children'; | |||
import { contextConnect, useContextSystem } from '../ui/context'; | |||
// eslint-disable-next-line no-duplicate-imports | |||
import type { PolymorphicComponentProps } from '../ui/context'; | |||
import { View } from '../view'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we tracking the removal of the View
component (and the createComponent
function) anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will be removed as just a side effect of this work, I'm not sure it's necessary to track it separately.
Description
Part of #30503 (comment)
How has this been tested?
Storybook, everything all the props etc should all work as they worked before.
Types of changes
Non breaking change
Checklist:
*.native.js
files for terms that need renaming or removal).