Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostPublishButton: Disable if saving non-post entities #33140

Merged
merged 8 commits into from
Jul 8, 2021
Merged

PostPublishButton: Disable if saving non-post entities #33140

merged 8 commits into from
Jul 8, 2021

Commits on Jul 5, 2021

  1. core-data: Add __experimentalGetEntitiesBeingSaved() selector

    @ockham
    ockham committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    a085c04 View commit details
    Browse the repository at this point in the history

  2. Editor: Add isSavingNonPostEntityChanges() selector

    @ockham
    ockham committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    c979ca3 View commit details
    Browse the repository at this point in the history

  3. PostPublishButton: Use isSavingNonPostEntityChanges() to determine bu… 

    …tton state
    @ockham
    ockham committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    8245031 View commit details
    Browse the repository at this point in the history

  4. Disable the Cancel button, too

    @ockham
    ockham committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    50e896f View commit details
    Browse the repository at this point in the history

  5. Add unit test for __experimentalGetEntitiesBeingSaved

    @ockham
    ockham committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    dc72ccb View commit details
    Browse the repository at this point in the history

  6. Add unit test coverage for isSavingNonPostEntityChanges

    @ockham
    ockham committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    ff1ca28 View commit details
    Browse the repository at this point in the history

  7. Typo

    @ockham
    ockham committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    73c59c2 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. Absorb non-post entity related criteria into is{Button|Toggle}Disabled

    @ockham
    ockham committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    61d0634 View commit details
    Browse the repository at this point in the history