Try stickily positioned legacy widget wide popover #33230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +384 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
7 tasks
stokesman
added
the
[Feature] Widgets Customizer
stokesman
added
[Block] Legacy Widget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #31736 and would close #32210 by obviating the need for it.
The idea was to mostly reproduce how wide widgets display their forms in the Customizer without the block editor.
This supports it with some modification to the
Popovercomponent to apply its layout calculations by way of CSS custom properties. It's a fairly light change and the feature could have application in other popover use cases but, for now, I'd rather not changePopoverand thus prefer #33236.How has this been tested?
Manually
Screenshots
customizer-widgets-sticky-wide-popover.mp4
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).