Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add group wrapper to the Standard alignment query block #33267

Closed
wants to merge 1 commit into from
Closed

Add group wrapper to the Standard alignment query block #33267

wants to merge 1 commit into from

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Jul 7, 2021

The bundled "Standard" query block pattern is missing a wrapper container to inherit the default layout settings. As a result:

  • The text extends the full width of the page.
  • The featured image is set to be wide-aligned, but it appears full-width instead.

This PR just adds a group block wrapper to ensure these are displaying as intended.

Before After
Screen Shot 2021-07-07 at 2 13 53 PM Screen Shot 2021-07-07 at 2 14 30 PM

@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Jul 7, 2021
@kjellr kjellr self-assigned this Jul 7, 2021
@kjellr
Copy link
Contributor Author

kjellr commented Jul 7, 2021

Actually, I'm going to close this one, because I think this is valid for more than just this pattern, and #30506 is more appropriate to re-open.

@kjellr kjellr closed this Jul 7, 2021
@kjellr kjellr deleted the fix/layout-for-standard-query-pattern branch January 13, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmussen jasmussen Awaiting requested review from jasmussen

@MaggieCabrera MaggieCabrera Awaiting requested review from MaggieCabrera

@ntsekouras ntsekouras Awaiting requested review from ntsekouras

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

Assignees

@kjellr kjellr

Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kjellr