Skip unstable e2e tests #33352
Merged
Skip unstable e2e tests #33352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Automated Testing
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
|
@getdave was able to track down the issue with I will start working on the fix today since I think Dave is busy working on other issues. |
|
@Mamaduka that's great to hear, thanks :) |
|
@youknowriad Sorry about that! The fix in core was intended to help the tests become more stable (through allowing reducing the test times/timeouts), not less. It's still not clear to me why it would cause this test to fail. Looking at reproducing, and alternate approaches to solving the original issue. |
|
No worries @getsource I'm not sure either about it. @kevin940726 might know more. |
|
@getsource No worries! Feel free to ping me on Slack if you need more info :) |
youknowriad
added a commit
that referenced
this pull request
Jul 12, 2021
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
|
Just a quick note that I reverted the change in core, so the @kevin940726 Thanks much for the offer -- would love work together on finding a fix. I left some details on the trac ticket with what I do and don't understand about the behavior so far. |
youknowriad
added a commit
that referenced
this pull request
Jul 13, 2021
7 tasks
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 15, 2021
|
I just merged #33362. I think we can re-enable the "Save flow should work as expected" test. |
|
@Mamaduka let's do it and restart two or three times on the PR and merge if stable |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, some e2e tests remain very unstable.
It's becoming very blocking for PRs and work on the repo. Please if you have some time, check some of the skipped e2e tests and try to enable them again.