Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flex layout support to the block editor #33359

Merged
merged 11 commits into from
Jul 26, 2021
Merged

Add flex layout support to the block editor #33359

merged 11 commits into from
Jul 26, 2021

Conversation

youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Jul 12, 2021

closes #24473
Related #27324

Note This is still in early stages and requires a lot of feedback and iterations.

In the previous WordPress release, we introduced the layout config and the __experimentalLayout prop for inner blocks. The initial reason for these was to make alignments and content widths more declarative for themes. While this was an ambitious goal on its own and a hard one to achieve for the default layout, the goal has always been to absorb and support more kinds of layouts in the editor than the regular vertical list of blocks: think about containers with grid or flex display, absolute positioning...

This PR introduces the first "non-default" layout, the flex layout. It's less ambitious than the grid layout but it will allow us to prove the multi-layout support.

In terms of UI: (this deserves a lot of design work, this is very rough on purpose for now, just to get it working)

  • This PR adds a layout type selector to the "group" block, meaning the group block can be now defined as having a "flex layout"
  • When a container has a flex layout, children of that container should be rendered as flex children (horizontally by default)
  • Several things need to happen to the editor UI (not implemented entirely yet)
    • By default, the movers and UI should adapt as if it was defined as "horizontal" orientation
    • Alignment controls from inner blocks should disappear
  • The container should allow defining a few properties for this layout (not implemented yet)
    • The gap (column or row gap)
    • The orientation (by default vertical for flex containers)
    • Align items (by default items are centered)
    • Justify content (by default nothing)

In terms of DevX and APIs:

  • This PRs adds a flag to the layout block support config to allow switching layout types for specific blocks, it's enabled for group blocks only right now. __experimentalLayout: { allowSwitching: true }
  • Extract all layout specific code (Edit component, generating styles, config) into layout type objects, adding a layout (like grid) would mean adding a new layout type object.

Notes

Right now, this layout is already used in several blocks in an adhoc way, the buttons, social icons and columns blocks are all blocks that should be using this layout instead of styling it in an adhoc way.

Testing instructions

  • Play a bit with the "layout" config for group blocks and share feedback. (the theme must have a theme.json file for the layout to be enabled)

@youknowriad youknowriad added Needs Design Needs design efforts. [Type] Feature New feature to highlight in changelogs. labels Jul 12, 2021
@youknowriad youknowriad requested review from mtias, kjellr, jasmussen and a team July 12, 2021 13:52
@youknowriad youknowriad self-assigned this Jul 12, 2021
@youknowriad youknowriad added the [Block] Group Affects the Group Block (and row, stack and grid variants) label Jul 12, 2021
@github-actions
Copy link

github-actions bot commented Jul 12, 2021

Size Change: +469 B (0%)

Total Size: 1.07 MB

Filename Size Change
build/a11y/index.min.js 1.12 kB +2 B (0%)
build/admin-manifest/index.min.js 1.41 kB -1 B (0%)
build/annotations/index.min.js 2.93 kB -1 B (0%)
build/block-editor/index.min.js 127 kB +692 B (+1%)
build/block-editor/style-rtl.css 14 kB +1 B (0%)
build/block-editor/style.css 14 kB +3 B (0%)
build/block-library/index.min.js 146 kB -210 B (0%)
build/blocks/index.min.js 47.2 kB -3 B (0%)
build/components/index.min.js 196 kB +24 B (0%)
build/compose/index.min.js 10.2 kB -7 B (0%)
build/core-data/index.min.js 12.4 kB -1 B (0%)
build/customize-widgets/index.min.js 10.3 kB -9 B (0%)
build/data-controls/index.min.js 829 B -1 B (0%)
build/data/index.min.js 7.22 kB -7 B (0%)
build/date/index.min.js 31.8 kB -2 B (0%)
build/deprecated/index.min.js 738 B +1 B (0%)
build/edit-navigation/index.min.js 13.9 kB +2 B (0%)
build/edit-post/index.min.js 59.4 kB -57 B (0%)
build/edit-site/index.min.js 26 kB -4 B (0%)
build/edit-widgets/index.min.js 16.2 kB -10 B (0%)
build/editor/index.min.js 38.6 kB -10 B (0%)
build/element/index.min.js 3.44 kB +3 B (0%)
build/hooks/index.min.js 1.76 kB +1 B (0%)
build/i18n/index.min.js 3.73 kB +1 B (0%)
build/keycodes/index.min.js 1.49 kB +55 B (+4%)
build/list-reusable-blocks/index.min.js 2.07 kB +1 B (0%)
build/media-utils/index.min.js 3.08 kB +1 B (0%)
build/plugins/index.min.js 1.99 kB -3 B (0%)
build/priority-queue/index.min.js 791 B +1 B (0%)
build/redux-routine/index.min.js 2.82 kB +1 B (0%)
build/rich-text/index.min.js 10.8 kB -3 B (0%)
build/server-side-render/index.min.js 1.64 kB +2 B (0%)
build/shortcode/index.min.js 1.68 kB -1 B (0%)
build/token-list/index.min.js 848 B +1 B (0%)
build/warning/index.min.js 1.16 kB +5 B (0%)
build/widgets/index.min.js 6.48 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size
build/api-fetch/index.min.js 2.44 kB
build/autop/index.min.js 2.28 kB
build/blob/index.min.js 673 B
build/block-directory/index.min.js 6.61 kB
build/block-directory/style-rtl.css 1.02 kB
build/block-directory/style.css 1.02 kB
build/block-library/blocks/archives/editor-rtl.css 61 B
build/block-library/blocks/archives/editor.css 60 B
build/block-library/blocks/archives/style-rtl.css 65 B
build/block-library/blocks/archives/style.css 65 B
build/block-library/blocks/audio/editor-rtl.css 58 B
build/block-library/blocks/audio/editor.css 58 B
build/block-library/blocks/audio/style-rtl.css 112 B
build/block-library/blocks/audio/style.css 112 B
build/block-library/blocks/audio/theme-rtl.css 125 B
build/block-library/blocks/audio/theme.css 125 B
build/block-library/blocks/block/editor-rtl.css 161 B
build/block-library/blocks/block/editor.css 161 B
build/block-library/blocks/button/editor-rtl.css 475 B
build/block-library/blocks/button/editor.css 474 B
build/block-library/blocks/button/style-rtl.css 603 B
build/block-library/blocks/button/style.css 602 B
build/block-library/blocks/buttons/editor-rtl.css 315 B
build/block-library/blocks/buttons/editor.css 315 B
build/block-library/blocks/buttons/style-rtl.css 375 B
build/block-library/blocks/buttons/style.css 375 B
build/block-library/blocks/calendar/style-rtl.css 208 B
build/block-library/blocks/calendar/style.css 208 B
build/block-library/blocks/categories/editor-rtl.css 84 B
build/block-library/blocks/categories/editor.css 83 B
build/block-library/blocks/categories/style-rtl.css 79 B
build/block-library/blocks/categories/style.css 79 B
build/block-library/blocks/code/style-rtl.css 90 B
build/block-library/blocks/code/style.css 90 B
build/block-library/blocks/code/theme-rtl.css 131 B
build/block-library/blocks/code/theme.css 131 B
build/block-library/blocks/columns/editor-rtl.css 190 B
build/block-library/blocks/columns/editor.css 190 B
build/block-library/blocks/columns/style-rtl.css 475 B
build/block-library/blocks/columns/style.css 476 B
build/block-library/blocks/cover/editor-rtl.css 670 B
build/block-library/blocks/cover/editor.css 670 B
build/block-library/blocks/cover/style-rtl.css 1.22 kB
build/block-library/blocks/cover/style.css 1.23 kB
build/block-library/blocks/embed/editor-rtl.css 486 B
build/block-library/blocks/embed/editor.css 486 B
build/block-library/blocks/embed/style-rtl.css 401 B
build/block-library/blocks/embed/style.css 400 B
build/block-library/blocks/embed/theme-rtl.css 124 B
build/block-library/blocks/embed/theme.css 124 B
build/block-library/blocks/file/editor-rtl.css 301 B
build/block-library/blocks/file/editor.css 300 B
build/block-library/blocks/file/style-rtl.css 255 B
build/block-library/blocks/file/style.css 255 B
build/block-library/blocks/file/view.min.js 711 B
build/block-library/blocks/freeform/editor-rtl.css 2.44 kB
build/block-library/blocks/freeform/editor.css 2.44 kB
build/block-library/blocks/gallery/editor-rtl.css 704 B
build/block-library/blocks/gallery/editor.css 705 B
build/block-library/blocks/gallery/style-rtl.css 1.06 kB
build/block-library/blocks/gallery/style.css 1.06 kB
build/block-library/blocks/gallery/theme-rtl.css 122 B
build/block-library/blocks/gallery/theme.css 122 B
build/block-library/blocks/group/editor-rtl.css 160 B
build/block-library/blocks/group/editor.css 160 B
build/block-library/blocks/group/style-rtl.css 57 B
build/block-library/blocks/group/style.css 57 B
build/block-library/blocks/group/theme-rtl.css 93 B
build/block-library/blocks/group/theme.css 93 B
build/block-library/blocks/heading/editor-rtl.css 152 B
build/block-library/blocks/heading/editor.css 152 B
build/block-library/blocks/heading/style-rtl.css 76 B
build/block-library/blocks/heading/style.css 76 B
build/block-library/blocks/home-link/style-rtl.css 247 B
build/block-library/blocks/home-link/style.css 247 B
build/block-library/blocks/html/editor-rtl.css 281 B
build/block-library/blocks/html/editor.css 281 B
build/block-library/blocks/image/editor-rtl.css 729 B
build/block-library/blocks/image/editor.css 727 B
build/block-library/blocks/image/style-rtl.css 481 B
build/block-library/blocks/image/style.css 485 B
build/block-library/blocks/image/theme-rtl.css 124 B
build/block-library/blocks/image/theme.css 124 B
build/block-library/blocks/latest-comments/style-rtl.css 286 B
build/block-library/blocks/latest-comments/style.css 286 B
build/block-library/blocks/latest-posts/editor-rtl.css 137 B
build/block-library/blocks/latest-posts/editor.css 137 B
build/block-library/blocks/latest-posts/style-rtl.css 526 B
build/block-library/blocks/latest-posts/style.css 524 B
build/block-library/blocks/list/style-rtl.css 63 B
build/block-library/blocks/list/style.css 63 B
build/block-library/blocks/media-text/editor-rtl.css 263 B
build/block-library/blocks/media-text/editor.css 264 B
build/block-library/blocks/media-text/style-rtl.css 492 B
build/block-library/blocks/media-text/style.css 489 B
build/block-library/blocks/more/editor-rtl.css 434 B
build/block-library/blocks/more/editor.css 434 B
build/block-library/blocks/navigation-link/editor-rtl.css 474 B
build/block-library/blocks/navigation-link/editor.css 473 B
build/block-library/blocks/navigation-link/style-rtl.css 94 B
build/block-library/blocks/navigation-link/style.css 94 B
build/block-library/blocks/navigation/editor-rtl.css 1.69 kB
build/block-library/blocks/navigation/editor.css 1.69 kB
build/block-library/blocks/navigation/style-rtl.css 1.65 kB
build/block-library/blocks/navigation/style.css 1.66 kB
build/block-library/blocks/navigation/view.min.js 2.84 kB
build/block-library/blocks/nextpage/editor-rtl.css 395 B
build/block-library/blocks/nextpage/editor.css 395 B
build/block-library/blocks/page-list/editor-rtl.css 310 B
build/block-library/blocks/page-list/editor.css 311 B
build/block-library/blocks/page-list/style-rtl.css 240 B
build/block-library/blocks/page-list/style.css 240 B
build/block-library/blocks/paragraph/editor-rtl.css 157 B
build/block-library/blocks/paragraph/editor.css 157 B
build/block-library/blocks/paragraph/style-rtl.css 247 B
build/block-library/blocks/paragraph/style.css 248 B
build/block-library/blocks/post-author/editor-rtl.css 209 B
build/block-library/blocks/post-author/editor.css 209 B
build/block-library/blocks/post-author/style-rtl.css 183 B
build/block-library/blocks/post-author/style.css 184 B
build/block-library/blocks/post-comments-form/style-rtl.css 140 B
build/block-library/blocks/post-comments-form/style.css 140 B
build/block-library/blocks/post-comments/style-rtl.css 360 B
build/block-library/blocks/post-comments/style.css 359 B
build/block-library/blocks/post-content/editor-rtl.css 139 B
build/block-library/blocks/post-content/editor.css 139 B
build/block-library/blocks/post-excerpt/editor-rtl.css 73 B
build/block-library/blocks/post-excerpt/editor.css 73 B
build/block-library/blocks/post-excerpt/style-rtl.css 69 B
build/block-library/blocks/post-excerpt/style.css 69 B
build/block-library/blocks/post-featured-image/editor-rtl.css 338 B
build/block-library/blocks/post-featured-image/editor.css 338 B
build/block-library/blocks/post-featured-image/style-rtl.css 141 B
build/block-library/blocks/post-featured-image/style.css 141 B
build/block-library/blocks/post-template/editor-rtl.css 100 B
build/block-library/blocks/post-template/editor.css 99 B
build/block-library/blocks/post-template/style-rtl.css 379 B
build/block-library/blocks/post-template/style.css 380 B
build/block-library/blocks/post-terms/style-rtl.css 73 B
build/block-library/blocks/post-terms/style.css 73 B
build/block-library/blocks/post-title/style-rtl.css 60 B
build/block-library/blocks/post-title/style.css 60 B
build/block-library/blocks/preformatted/style-rtl.css 103 B
build/block-library/blocks/preformatted/style.css 103 B
build/block-library/blocks/pullquote/editor-rtl.css 198 B
build/block-library/blocks/pullquote/editor.css 198 B
build/block-library/blocks/pullquote/style-rtl.css 362 B
build/block-library/blocks/pullquote/style.css 361 B
build/block-library/blocks/pullquote/theme-rtl.css 169 B
build/block-library/blocks/pullquote/theme.css 169 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B
build/block-library/blocks/query-pagination/editor-rtl.css 270 B
build/block-library/blocks/query-pagination/editor.css 262 B
build/block-library/blocks/query-pagination/style-rtl.css 168 B
build/block-library/blocks/query-pagination/style.css 168 B
build/block-library/blocks/query-title/editor-rtl.css 86 B
build/block-library/blocks/query-title/editor.css 86 B
build/block-library/blocks/query/editor-rtl.css 131 B
build/block-library/blocks/query/editor.css 132 B
build/block-library/blocks/quote/style-rtl.css 169 B
build/block-library/blocks/quote/style.css 169 B
build/block-library/blocks/quote/theme-rtl.css 221 B
build/block-library/blocks/quote/theme.css 221 B
build/block-library/blocks/rss/editor-rtl.css 201 B
build/block-library/blocks/rss/editor.css 202 B
build/block-library/blocks/rss/style-rtl.css 290 B
build/block-library/blocks/rss/style.css 290 B
build/block-library/blocks/search/editor-rtl.css 211 B
build/block-library/blocks/search/editor.css 211 B
build/block-library/blocks/search/style-rtl.css 359 B
build/block-library/blocks/search/style.css 362 B
build/block-library/blocks/search/theme-rtl.css 64 B
build/block-library/blocks/search/theme.css 64 B
build/block-library/blocks/separator/editor-rtl.css 99 B
build/block-library/blocks/separator/editor.css 99 B
build/block-library/blocks/separator/style-rtl.css 251 B
build/block-library/blocks/separator/style.css 251 B
build/block-library/blocks/separator/theme-rtl.css 172 B
build/block-library/blocks/separator/theme.css 172 B
build/block-library/blocks/shortcode/editor-rtl.css 476 B
build/block-library/blocks/shortcode/editor.css 476 B
build/block-library/blocks/site-logo/editor-rtl.css 465 B
build/block-library/blocks/site-logo/editor.css 465 B
build/block-library/blocks/site-logo/style-rtl.css 154 B
build/block-library/blocks/site-logo/style.css 154 B
build/block-library/blocks/site-tagline/editor-rtl.css 87 B
build/block-library/blocks/site-tagline/editor.css 87 B
build/block-library/blocks/site-title/editor-rtl.css 85 B
build/block-library/blocks/site-title/editor.css 85 B
build/block-library/blocks/social-link/editor-rtl.css 164 B
build/block-library/blocks/social-link/editor.css 165 B
build/block-library/blocks/social-links/editor-rtl.css 800 B
build/block-library/blocks/social-links/editor.css 799 B
build/block-library/blocks/social-links/style-rtl.css 1.34 kB
build/block-library/blocks/social-links/style.css 1.34 kB
build/block-library/blocks/spacer/editor-rtl.css 308 B
build/block-library/blocks/spacer/editor.css 308 B
build/block-library/blocks/spacer/style-rtl.css 48 B
build/block-library/blocks/spacer/style.css 48 B
build/block-library/blocks/table/editor-rtl.css 478 B
build/block-library/blocks/table/editor.css 478 B
build/block-library/blocks/table/style-rtl.css 480 B
build/block-library/blocks/table/style.css 480 B
build/block-library/blocks/table/theme-rtl.css 188 B
build/block-library/blocks/table/theme.css 188 B
build/block-library/blocks/tag-cloud/style-rtl.css 146 B
build/block-library/blocks/tag-cloud/style.css 146 B
build/block-library/blocks/template-part/editor-rtl.css 551 B
build/block-library/blocks/template-part/editor.css 550 B
build/block-library/blocks/template-part/theme-rtl.css 101 B
build/block-library/blocks/template-part/theme.css 101 B
build/block-library/blocks/term-description/editor-rtl.css 90 B
build/block-library/blocks/term-description/editor.css 90 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B
build/block-library/blocks/text-columns/editor.css 95 B
build/block-library/blocks/text-columns/style-rtl.css 166 B
build/block-library/blocks/text-columns/style.css 166 B
build/block-library/blocks/verse/style-rtl.css 87 B
build/block-library/blocks/verse/style.css 87 B
build/block-library/blocks/video/editor-rtl.css 569 B
build/block-library/blocks/video/editor.css 570 B
build/block-library/blocks/video/style-rtl.css 173 B
build/block-library/blocks/video/style.css 173 B
build/block-library/blocks/video/theme-rtl.css 124 B
build/block-library/blocks/video/theme.css 124 B
build/block-library/common-rtl.css 1.29 kB
build/block-library/common.css 1.29 kB
build/block-library/editor-rtl.css 9.83 kB
build/block-library/editor.css 9.83 kB
build/block-library/reset-rtl.css 514 B
build/block-library/reset.css 515 B
build/block-library/style-rtl.css 10.3 kB
build/block-library/style.css 10.3 kB
build/block-library/theme-rtl.css 692 B
build/block-library/theme.css 693 B
build/block-serialization-default-parser/index.min.js 1.3 kB
build/block-serialization-spec-parser/index.min.js 3.06 kB
build/components/style-rtl.css 15.9 kB
build/components/style.css 15.9 kB
build/customize-widgets/style-rtl.css 1.48 kB
build/customize-widgets/style.css 1.48 kB
build/dom-ready/index.min.js 576 B
build/dom/index.min.js 4.78 kB
build/edit-navigation/style-rtl.css 3.12 kB
build/edit-navigation/style.css 3.12 kB
build/edit-post/classic-rtl.css 483 B
build/edit-post/classic.css 483 B
build/edit-post/style-rtl.css 7.25 kB
build/edit-post/style.css 7.24 kB
build/edit-site/style-rtl.css 5.04 kB
build/edit-site/style.css 5.03 kB
build/edit-widgets/style-rtl.css 3.99 kB
build/edit-widgets/style.css 3.99 kB
build/editor/style-rtl.css 3.88 kB
build/editor/style.css 3.88 kB
build/escape-html/index.min.js 739 B
build/format-library/index.min.js 5.71 kB
build/format-library/style-rtl.css 668 B
build/format-library/style.css 669 B
build/html-entities/index.min.js 628 B
build/is-shallow-equal/index.min.js 710 B
build/keyboard-shortcuts/index.min.js 1.74 kB
build/list-reusable-blocks/style-rtl.css 842 B
build/list-reusable-blocks/style.css 842 B
build/notices/index.min.js 1.07 kB
build/nux/index.min.js 2.31 kB
build/nux/style-rtl.css 745 B
build/nux/style.css 742 B
build/primitives/index.min.js 1.06 kB
build/react-i18n/index.min.js 924 B
build/reusable-blocks/index.min.js 2.56 kB
build/reusable-blocks/style-rtl.css 256 B
build/reusable-blocks/style.css 256 B
build/url/index.min.js 1.95 kB
build/viewport/index.min.js 1.28 kB
build/widgets/style-rtl.css 1.04 kB
build/widgets/style.css 1.05 kB
build/wordcount/index.min.js 1.24 kB

compressed-size-action

@kjellr
Copy link
Contributor

kjellr commented Jul 12, 2021

This is cool. Here's what I'm seeing:

flex

We'll definitely need a new name for this... "flex" isn't going to mean much to users. I wonder if to start we just frame this as a default vertical layout versus a horizontal one?

@mtias
Copy link
Member

mtias commented Jul 13, 2021

Probably worth keeping this UI-less for a bit. Also worth clarifying that position is going to be somewhat orthogonal to layout.

I wonder if to start we just frame this as a default vertical layout versus a horizontal one?

Even for vertical layouts we'd want to use flex in some cases to take advantage of better positioning (Cover comes to mind with its matrix alignment, which can be well suited for flex).

@tellthemachines
Copy link
Contributor

Nice feature! I wonder if we could use this in the Navigation block instead of having the horizontal/vertical variations. If inner blocks can change their behaviour according to the parent's layout, that would allow us to solve the Spacer block orientation issue in a more general way (currently Spacer inherits its orientation from context, which is only enabled in the Navigation block).

Testing the group block with these changes, I'm seeing the align options have been removed from it:

Screen Shot 2021-07-14 at 11 46 33 am

I was expecting to be able to set a Group to use wide or full width, and have an internal flex layout.

Might be worth adding to the testing notes that this only works on a FSE theme, it wasn't obvious to me 😅 (I'm assuming that's on purpose? It would be neat to have it work globally though)

@youknowriad
Copy link
Contributor Author

I was expecting to be able to set a Group to use wide or full width, and have an internal flex layout.

This expectation is right, I can do it still but maybe there's some edge case somewhere.

I wonder if we could use this in the Navigation block instead of having the horizontal/vertical variations.

Yeah, I'd love if ultimately all blocks use "layout" instead of adding custom CSS for their children to align them as they should.

Might be worth adding to the testing notes that this only works on a FSE theme, it wasn't obvious to me 😅 (I'm assuming that's on purpose? It would be neat to have it work globally though)

Good point, the reason is simple "layout" only works for themes with theme.json file because of unsolvable backward compatibility issues. But that concerns the "default/flow" layout mostly, maybe we could find a way to make these alternative layouts work for these (probably later though).

@youknowriad youknowriad mentioned this pull request Jul 26, 2021
5 tasks
@youknowriad
Copy link
Contributor Author

I removed the layout switcher from the Group block and I opened this issue to track the follow-up tasks #33687

This PR should be ready to merge now.

Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Riad! Let's land and start the next iterations 💯

@youknowriad youknowriad merged commit bf405a3 into trunk Jul 26, 2021
@youknowriad youknowriad deleted the add/flex-layout branch July 26, 2021 08:59
@youknowriad youknowriad added [Type] Experimental Experimental feature or API. and removed [Type] Feature New feature to highlight in changelogs. labels Jul 26, 2021
@github-actions github-actions bot added this to the Gutenberg 11.2 milestone Jul 26, 2021
@jasmussen
Copy link
Contributor

This is cool. It would pair really well with #33812 ;)

@MaggieCabrera
Copy link
Contributor

+1 on having some kind of control over the gap to avoid situations like this:

Current gap Gap 0
Screenshot 2021-08-04 at 09 25 38 Screenshot 2021-08-04 at 09 25 14

@paulwilde
Copy link
Contributor

I've noticed that the Gutenberg 11.2 update seems to have broke the ability to set all blocks as full width. I suspect this change might be the culprit for that loss in functionality?

@youknowriad
Copy link
Contributor Author

@paulwilde I'll take a look, what theme are you using?

@youknowriad
Copy link
Contributor Author

I can still see wide and full alignments personally, consider opening an issue with more details.

@paulwilde
Copy link
Contributor

paulwilde commented Aug 4, 2021

@paulwilde I'll take a look, what theme are you using?

It's a custom built theme. I tried using "Twenty Twenty-One" and I do see the options, but that theme doesn't appear to be using theme.json which seems to be where the issue is. If I entirely remove theme.json from my custom theme the options appear again.

I'll go ahead and do your suggestion of creating a separate ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block (and row, stack and grid variants) Needs Design Needs design efforts. [Type] Experimental Experimental feature or API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group Block: Add a ‘display horizontal’ option
8 participants