Mobile - Global styles: Font sizes and line height data #33390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Status] In Progress
|
Size Change: +4.09 kB (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
enejb
reviewed
Jul 13, 2021
packages/components/src/mobile/global-styles-context/utils.native.js
Outdated
Show resolved
Hide resolved
enejb
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support to parse nested custom variables as well as passing font-size and line-height data to the mobile editor.
It also tweaks the rich text component to load the default text color of the theme.
How has this been tested?
Since this new data is not being used yet, the only test needed is to double-check the current global styles colors implementation works correctly.
Screenshots
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).