-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove event.stopPropagation for past WritingFlow/ObserveTyping compatibility #33632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
ajitbohra,
chrisvanpatten and
mkevins
as code owners
July 22, 2021 15:57
Size Change: -132 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 26, 2021
This was referenced Sep 17, 2021
shimotmk
added a commit
to vektor-inc/vk-blocks-pro
that referenced
this pull request
Jan 14, 2022
event.stopPropagationを削除 関連 : WordPress/gutenberg#33632
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These component used to be rendered inside the block's React tree, which meant WritingFlow and ObserveTyping would previously be triggered for these components. This is no longer needed because:
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).