-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing Overview: update JS example to use React Testing Library #34423
Conversation
In addition to |
Co-authored-by: Haz <hazdiego@gmail.com>
Co-authored-by: Haz <hazdiego@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some tiny details to discuss before this lands.
Anyway, overall these changes look great. Thank you very much for bringing so desperately needed refresh to testing overview ❤️
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
Absolutely! I've added a paragraph about it in @gziolo @sarayourfriend @diegohaz all feedback so far should have been tackled, let me know if there's anything else you'd like to see amended! |
You can wait for @diegohaz for his feedback because he is more experienced with testing components 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! Thanks @ciampo! 🚀
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
Description
As agreed in #33960 (comment), this PR updates the JS section of the
Testing Overview
docs:toMatchDiffSnapshot
functionHow has this been tested?
👀
Screenshots
Types of changes
Docs
Checklist:
*.native.js
files for terms that need renaming or removal).