Remove colors classes from the packages that are already provided by global styles #34510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these are enqueued already via the global stylesheet.
these are enqueued already via the global stylesheet.
these are enqueued already via the global stylesheet.
oandregal
added
[Type] Performance
This was referenced Sep 2, 2021
oandregal
changed the title
|
Size Change: -2.08 kB (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Sep 3, 2021
oandregal
commented
Sep 3, 2021
| @mixin gradient-colors() { | ||
| // Our classes uses the same values we set for gradient value attributes, and we can not use spacing because of WP multi site kses rule. | ||
| // Deprecated from UI, kept for back-compat. | ||
| @mixin gradient-colors-deprecated() { |
There was a problem hiding this comment.
Upon reviewing the list with fresh eyes today, I've found that there were some gradient colors that are deprecated (no longer in the list of gradients we offer but need to keep in case they had been used). Added them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34138
This is the second try. We first tried it at #33924 that had to be reverted at #34108 The reason for the revert was that not all themes had the color classes. For example, classic themes that don't provide a palette. This is now solved because we landed #34334 that enqueues the presets for all themes.
How to test
The following instructions work for both the front-end and the editor and any kind of theme:
wp-block-library-cssstylesheet.trunk, if you inspected the same stylesheet you should also find the CSS for the black color which you should not with this PR:Theme with
theme.jsonand no colors providedsettings.color.paletteandsettings.color.gradientssection.Theme without
theme.jsonand no colors providedfunctions.phpfile and comment this line: