Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text-menu min widths. #34532

Merged
merged 2 commits into from
Sep 3, 2021
Merged

Fix text-menu min widths. #34532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a5aae9
Fix text-menu min widths.
jasmussen Sep 3, 2021
19140eb
Update changelog to indicate the min-width removal can be breaking.
jasmussen Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/block-editor/src/components/media-placeholder/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// Selector requires a lot of specificity to override base styles.
input[type="url"].block-editor-media-placeholder__url-input-field {
width: 100%;
min-width: 200px;

@include break-small() {
width: 300px;
}
Expand Down
4 changes: 4 additions & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Breaking Change

- Removed a min-width from the `DropdownMenu` component, allowing the menu to accommodate thin contents like vertical tools menus ([#33995](https://github.com/WordPress/gutenberg/pull/33995)).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if this sounds good.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I was initially confused since this PR adds two min-widths and not removing, but docs are for previous PR 👍


### Bug Fix

- Fixed RTL styles in `Flex` component ([#33729](https://github.com/WordPress/gutenberg/pull/33729)).
Expand Down
3 changes: 3 additions & 0 deletions packages/components/src/menu-item/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,10 @@
}

.components-menu-item__item {
// Provide a minimum width for text items in menus.
white-space: nowrap;
min-width: 160px;

margin-right: auto;
display: inline-flex;
align-items: center;
Expand Down