-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add undo redo buttons in navigation editor #34533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Size Change: +599 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work adding the undo/redo!
Not sure what's happening here but clicking Redo doesn't seem to restore the changes I just "undid".
To replicate:
- Add x3 links to the Navigation.
- Click Undo to revert the adding of the links.
- Click Redo to restore the links.
- See that you can't do this. There is only 1 level of redos available.
Also notice how everytime I click "Undo" it requires x3 clicks to remove a menu item that was added, rather than the x2 I would expect.
Kapture.2021-09-03.at.15.26.54.mp4
There's audio commentary on the video above which might help.
@getdave Good catch. I did some further testing and it doesn't seem to be caused by this PR. The editor already had undo/redo functionality via shortcut keys and the problem same can be reproduced in Testing in the post editor, the navigation block also has the same issue there, so I think this is a deeper problem than just the navigation editor. I'm going to move ahead with merging this, but I've made a bug report for the problem and will look into that further - #34564. |
Valid bug, but not caused by this PR
eae0819
to
d5d5f30
Compare
I found a fix for the undo/redo issue in #34565. |
Description
Another iteration on the editor header to bring more consistency between this and the widgets screen.
Most of the code is lifted straight from widgets.
How has this been tested?
It should work the same as using the shortcuts
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.js
files for terms that need renaming or removal).