ItemGroup: add story showcasing more complex layouts #34708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Package] Components
|
Size Change: 0 B Total Size: 1.05 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Sep 10, 2021
|
Nice! When possible, let's try the borders as 20% of 000000.
Here's the original reference:
|
ciampo
force-pushed
the
feat/components-item-group-complex-layout-story
branch
from
9f94495 to
a218ed7
Compare
Thank you for the feedback, @pablohoneyhoney. I've updated this specific Storybook example to be 20% of Out of curiosity, should this be the border color for all component's borders (e.g. the |
ciampo
force-pushed
the
feat/components-item-group-complex-layout-story
branch
from
b1c7488 to
10d5636
Compare
ciampo
added
[Type] Enhancement
We'd need to see them in context to value if the difference matters, but let's try it. @ciampo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new Storybook story for the
ItemGroupcomponent that helps showcasing how to use this component to create more complex UIs.This example is also going to help to investigate the current limitations on
ItemGroupwhen integrating it with other components.How has this been tested?
Screenshots
Types of changes
New feature (new story)
Checklist:
*.native.jsfiles for terms that need renaming or removal).