FontAppearanceControl: Remove fieldset wrapper
#35461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -22 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
mtias
approved these changes
Oct 8, 2021
ciampo
reviewed
Oct 11, 2021
There was a problem hiding this comment.
Sorry for being late with the review!
(Might've been copypasta?)
Probably. It looks like only components in the block-editor package use fieldset.
I was just wondering if we should add a CHANGELOG note about this? Removing the fieldset and changing the className targeting the select element may have introduced breaking changes to users of this component — so maybe a changelog entry can at least help with tracking this change.
On a separate note, I have also added a few labels to ease the Gutenberg release notes gathering process.
ciampo
added
[Feature] Component System
It might also have been a leftover from earlier iterations when font style was separate from font-weight and initially contained normal, italic & oblique controls. |
7 tasks
Opened #35585 to add a CHANGELOG entry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
FontAppearanceControlwas wrapped by afieldsettag that relied on a wp-admin CSS reset file (common.css). Rather than encapsulate a style reset within the component, I think it would be better to remove thefieldsetwrapper since AFAICT it serves no purpose in this particular case. (Might've been copypasta?)How has this been tested?
fieldsetstyling is gone in the Storybook.Screenshots
Before
When rendered in an isolated environment, the
fieldsetborder is visible.Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).