Provide some editor defaults for themes that do not provide any editor styles #35737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
oandregal
added
[Type] Bug
This was referenced Oct 18, 2021
|
Size Change: -6 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
I can see an improvement when testing for sure, but not a full match to the appearance on the previous Gutenberg release. Using Nucleare as a test theme again: v11.6.0 v11.7.0 This PR This is just one theme, and I recognize system-provided defaults won't be an exact match for every use case, but the line height in particular does feel a little cramped still. Can/should we add or edit a default for that attribute? |
youknowriad
reviewed
Oct 20, 2021
| return hasThemeStyles && settings.styles?.length | ||
| ? settings.styles | ||
| : settings.defaultEditorStyles; | ||
| return hasThemeStyles && settings.styles?.length ? settings.styles : []; |
There was a problem hiding this comment.
This seems to remove the "default theme styles" from themes when they uncheck "use theme styles", right?
There was a problem hiding this comment.
I'm not sure I understand this code very well :) Specifically, the role of hasThemeStyles and where that comes from.
This is what I understand:
- Add default editor styles applied to themes without theme.json and without editor styles #34439 added some default styles for themes that didn't have any. That was added in the client and relied on
settings.stylesbeing empty. - Enqueue preset styles for all themes in the editor #35424 made
settings.stylesto always have something (the core presets), hence it broke the changes introduced in 34439. - This PR tries to add again the default styles but it does it in the server (see) instead of the client as 34439 did.
I have an alternative PR to this one that still adds the default styles in the client but passes a flag to ignore the ones we add for core presets. See #35736 However, I thought this one was a better approach. I certainly don't have the full picture yet, though.
There was a problem hiding this comment.
When you go the "preferences" of the block editor, you can disable "theme styles", when disabled (for any theme), the default editor styles should be used.
There was a problem hiding this comment.
Oh, so there are a couple of cases here: the theme does not provide any style or the user deactivates theme styles. 🤔
If the theme styles depend on a user's action we need to be able to load different styles in the client. This PR doesn't make much sense then. I'll close this and focus on #35736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35730
Follow up to #35424 and #34439
Alternative to #35736
In Gutenberg 11.5, we added some defaults for themes that didn't enqueue any editor styles, see #34439
In Gutenberg 11.7, we made every theme to have some styles in the editor: we provided at least the core presets. See #35424 As an unintended side effect of this change, there are no themes that don't provide editor styles anymore, hence we didn't provide any editor defaults for them.
This PR adds back some defaults for themes that don't provide any editor styles.