Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] - Update Xcode version to 12.5 #35754

Merged
merged 2 commits into from
Oct 19, 2021
Merged

[Mobile] - Update Xcode version to 12.5 #35754

merged 2 commits into from
Oct 19, 2021

Conversation

geriux
Copy link
Member

@geriux geriux commented Oct 19, 2021 •
edited
Loading

Description

Github actions removed support for older versions of Xcode <=12.5 so this PR changes it to 12.5.1. Thanks to @fluiddot for sharing that link! 🙇

How has this been tested?

CI checks should pass

Screenshots

N/A

Types of changes

CI Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@geriux geriux added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Oct 19, 2021
@geriux geriux requested a review from fluiddot October 19, 2021 10:51
@geriux geriux marked this pull request as ready for review October 19, 2021 10:51
Mamaduka
Mamaduka approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks, @geriux.

fluiddot
fluiddot approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @geriux 💯 !
LGTM 🎊 !

NOTE: Now on the default Xcode version is 13.0 in the latest macOS image (reference).

@geriux geriux merged commit ecd87ca into trunk Oct 19, 2021
@geriux geriux deleted the rnmobile/update-xcode-version-ci branch October 19, 2021 11:51
@github-actions github-actions bot added this to the Gutenberg 11.8 milestone Oct 19, 2021
This was referenced Oct 19, 2021
Merged
Merged
@fluiddot fluiddot mentioned this pull request Oct 22, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot approved these changes

@Mamaduka Mamaduka Mamaduka approved these changes

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 11.8
Development

Successfully merging this pull request may close these issues.
3 participants
@geriux @Mamaduka @fluiddot