Fixes #34855 RangeControl style issue in RTL #35777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
reviewed
Oct 20, 2021
| @@ -192,7 +192,7 @@ export const ThumbWrapper = styled.span` | |||
| transform: translateX( 4.5px ); | |||
|
|
|||
| ${ thumbColor }; | |||
| ${ rtl( { marginLeft: -10 } ) }; | |||
| ${ rtl( { marginLeft: -10 }, { marginRight: 1 } ) }; | |||
There was a problem hiding this comment.
I'm not sure it makes sense that a symmetrical element like this requires asymmetrical margins. In fact the translateX( 4.5px ) a few lines above stands out to me as something that is not being RTL'ed yet. That might also fix the tooltip, which still isn't perfectly aligned.
There was a problem hiding this comment.
change the translate didn't fix it
but I was able to tweak the position of the dot so it lines up better
There was a problem hiding this comment.
Hmm, have we tried something like this yet? The reason I would prefer a symmetric solution if possible is that it's easier to fix when an underlying size value changes. Less guess work and manual tweaking involved.
- transform: translateX( 4.5px );
${ thumbColor };
- ${ rtl( { marginLeft: -10 }, { marginRight: 1 } ) };
+ ${ rtl( { marginLeft: -10 } ) };
+ ${ rtl(
+ { transform: 'translateX( 4.5px )' },
+ { transform: 'translateX( -4.5px )' }
+ ) };
mirka
approved these changes
Oct 25, 2021
vcanales
pushed a commit
that referenced
this pull request
Oct 27, 2021
* Fixes #34855 RangeControl style issue in RTL * addjest the dot offset so it lines up with tool tip * swapped to using translateX for the adjustment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #34855 RangeControl style issue in RTL
How has this been tested?
Switch RTL lag (hebrew)
load the space block
check the
Screenshots
Types of changes
Adjusted style for RTL
Checklist:
*.native.jsfiles for terms that need renaming or removal).