Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Disable React Native E2E Tests (iOS) #35844

Merged
merged 2 commits into from
Oct 21, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Oct 21, 2021

Description

We're recently experimenting failures when running the RN E2E tests in iOS, for this reason, we decided to temporarily disable this workflow until we manage to fix the issue.

How has this been tested?

Verify that the React Native E2E Tests (iOS) workflow is not triggered in the PR checks.

Screenshots

N/A

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@fluiddot fluiddot added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Oct 21, 2021
@fluiddot fluiddot requested a review from geriux October 21, 2021 16:39
@fluiddot fluiddot self-assigned this Oct 21, 2021
@fluiddot
Copy link
Contributor Author

Heads up that I pushed an empty commit because I forgot to re-enable the React Native E2E Tests (iOS) workflow 😅 .

Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I see the job disabled:

React Native E2E Tests (iOS) / test (pull_request) Skipped

@fluiddot fluiddot merged commit 3119c78 into trunk Oct 21, 2021
@fluiddot fluiddot deleted the rnmobile/disable-e2e-rn-ios-tests branch October 21, 2021 17:29
@github-actions github-actions bot added this to the Gutenberg 11.9 milestone Oct 21, 2021
fullofcaffeine added a commit that referenced this pull request Oct 21, 2021
* trunk: (494 commits)
  remove consecutive rc warning (#35855)
  Update Changelog for 11.8.0-rc.2
  Bump plugin version to 11.8.0-rc.2
  [RNMobile] Disable React Native E2E Tests (iOS) (#35844)
  Add section about using the schema during development (#35835)
  Add a method to disable auto-accepting dialogs (#35828)
  Wrap NavigationContainer with SafeAreaView. (#35570)
  Update Appium to 1.22.0 (#35829)
  Post Comment: Handle the case where a comment does not exist (#35810)
  Clear selected block when clicking on the gray background (#35816)
  Post excerpt: Don't print the wrapper when there is no excerpt (#35749)
  [Block] Navigation: Fix padding for social links on mobile (#35824)
  Fix issue with responsive navigation causing wrapping. (#35820)
  [Block Editor]: Fix displaying only `none` alignment option (#35822)
  Add API to access global settings, styles, and stylesheet (#34843)
  Mobile Release v1.64.1 (#35804)
  Add resizer to template part focus mode (#35728)
  Update Changelog for 11.7.1
  Gallery block: Only show the gallery upload error message if mixed multiple files uploaded (#35790)
  Update Changelog for 11.8.0-rc.1
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants