-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add block.json schema defintion to core blocks #35900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this is a good direction that should help improve the experience for maintaining block.json
files in the project. We should land this PR after the issues listed in #35902 get resolved to avoid confusion for those contributors who might see violations reported in their IDEs.
8a87842
to
e9aca74
Compare
We likely will want to wait on this merge as hopefully we can change it over to our own URLs based on this request: |
I'm not familiar with |
e9aca74
to
07faecc
Compare
Adds the schema defintion to the top of each core block to help development, in supported editors the schema definition will show validation errors, offer tooltips and autocomplete. Schema definition: "$schema": "https://json.schemastore.org/block.json",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
Opened #36351 as a follow-up to add a missing |
Description
Adds the schema defintion to the top of each core block to help development, in
supported editors the schema definition will show validation errors, offer
tooltips and autocomplete.
Schema definition:
How has this been tested?
Types of changes
Adds schema to top of each block.json file in core blocks. While going through and adding Prettier did format a couple of files so some minor whitespace, and array changes, nothing functional.
I did not correct any validation issues in this PR, I will create a new one with details on issues found by adding the schema. I'm not necessarily sure if the issues are with the schema definition or the block.json file.