Post Terms: Prevent the block from breaking on pages #35957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5.6 kB (+1%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
carolinan
added
[Block] Post Terms
ntsekouras
reviewed
Oct 27, 2021
There was a problem hiding this comment.
Thanks @carolinan ! I left a small comment but this looks good.
| @@ -9,6 +9,11 @@ export default function usePostTerms( { postId, postType, term } ) { | |||
| const [ termIds ] = useEntityProp( 'postType', postType, restBase, postId ); | |||
| return useSelect( | |||
| ( select ) => { | |||
| const termPostType = term?.types; | |||
| if ( ! termIds && termPostType !== postType ) { | |||
There was a problem hiding this comment.
term.types is an array and also we could combine this check with inside the existing if ( !termIds ) like this:
return { isLoading: term?.postTerms?.includes( postType ) };
There was a problem hiding this comment.
I don't understand how it works but I have made the change.
There was a problem hiding this comment.
If termIds from useEntityProp resolve properly they will return an empty array, which is handled right below. So when if ( !termIds ) is either while resolving or it will never find the requested entity and termIds will be undefined for ever. Makes sense?
2 tasks
andrewserong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Post Categories & Post Tags Blocks don't work if you insert them into a page.
After adding either of these blocks into your content, you simply get a spinning icon and nothing else.
This PR attempts to check if the
typessupported by the term is the same as the current post type.If the
termIddoes not exist, and if thetypesand post type are not the same, the loading state is returned as false,and the spinner is no longer shown.
Instead of the spinner, the message that is displayed is "No tags" and "No categories" respectively.
Closes #34212
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).