Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ColorPicker Maximum Call Stack Exceed / Memory Leak #36378

Conversation

delowardev
Copy link
Contributor

@delowardev delowardev commented Nov 10, 2021

Description

Added debounce function to prevent Maximum call stack exceeds limit

See: #36337

How has this been tested?

  • Checked inside Storybook.
  • Test case has been updated.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@delowardev delowardev changed the title Fix: ColorPicker Maximum Call Stack Exceed Fix: ColorPicker Maximum Call Stack Exceed / Memory Leak Nov 10, 2021
@skorasaurus skorasaurus added the [Package] Components /packages/components label Nov 13, 2021
@mirka
Copy link
Member

mirka commented Dec 2, 2021

Oops, I'm afraid we duplicated some work, and a debounce fix was merged recently in #36941. I confirmed that the issue is fixed in the current Storybook story.

Thanks for looking into it 🙏

@mirka mirka closed this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants