-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editor: Add global styles to export file #36619
Conversation
The constant isn't support in older version of PHP
Just wanted to say thank you for working on this <3 |
When I export Twenty Twenty-Two (GitHub version, not WP trunk) without changes the resulting theme.json is not valid.
gist with complete output: |
Thanks for testing, @carolinan. I'll look into that issue. |
@oandregal Is it possible to merge data without setting origins? |
Thank you soo much for working on this :). I'll dive into it deeper today and on the first look noticed the same thing @carolinan already wrote |
👋 Took a quick look and this and discussed it with George as well. It sounds like this feature is useful to export something people can bootstrap themes with. Going with that, it makes sense, in my view, to export the result of merging only theme and user data. This is straightforward for the At the moment, we don't have a way to merge |
+1 for contain the theme colors plus the user modifications, |
Closing this PR in favor of #39048. |
Description
Fixes #27528.
Adds global style settings (as theme.json) to the site export file.
P.S. I'm preparing the WP core patch for the missing export REST API. I think this will be a good addition to the functionality. We can polish the export feature after 5.9 - #27941.
How has this been tested?
Types of changes
Enhancement
Checklist:
*.native.js
files for terms that need renaming or removal).