Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to gutenberg_, swap with wp_ #36652

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

kebbet
Copy link
Contributor

@kebbet kebbet commented Nov 19, 2021

Closes #36651

Description

In WordPress trunk an option is named gutenberg_.
https://core.trac.wordpress.org/ticket/54446
In https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/blocks/calendar.php on line 103 (in the function block_core_calendar_update_has_published_posts) the option is named gutenberg_calendar_block_has_published_posts. Should it be called something else? The option is retrieved in the function block_core_calendar_has_published_posts some lines above, and may be updated as well.

Should be backported to WordPress 5.9.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@kebbet kebbet requested a review from ajitbohra as a code owner November 19, 2021 13:50
@SergeyBiryukov SergeyBiryukov added [Block] Calendar Affects the Calendar Block Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Nov 19, 2021
Copy link
Member

@SergeyBiryukov SergeyBiryukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The change looks good to me.

@Mamaduka Mamaduka merged commit fe7c3ae into WordPress:trunk Nov 23, 2021
@github-actions github-actions bot added this to the Gutenberg 12.1 milestone Nov 23, 2021
@noisysocks noisysocks removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Calendar Affects the Calendar Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove reference to gutenberg_, swap with wp_
4 participants