Fix: Clicking On Backspace Makes Reusable Block Modal Disappear

[delowardev]

Description

When creating a reusable block, if someone tries to delete a character from the block name by clicking backspace it removes all the selected blocks instead of deleting the character.

See: #36513

How has this been tested?

WP Version: 5.8.2
Device: Macbook Pro M1
OS: macOS Monterey

Please check the attached video on how to replicate and test.

Screenshots

reusable-block-backspace-bug.mp4

Types of changes

Bugfix

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• I've tested my changes with keyboard and screen readers.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

[Mamaduka]

Hi, @delowardev

@costdev mentioned that we'll need to check the DELETE keycode as well.

[delowardev]

Hi, @delowardev

@costdev mentioned that we'll need to check the DELETE keycode as well.

DELETE key check added in 83582bf

[Mamaduka]

Thank you, @delowardev.

[ntsekouras]

Thanks for the PR @delowardev !

This feels like there is a deeper underlying issue and we should try to dig deeper first.

[delowardev]

@ntsekouras
My point was it shouldn't fire delete events when the user is writing something ( when the input field is in focus ). But you're right, actually; another solution could be preventing the delete operation when the modal is open.

[ntsekouras]

Thanks for your work here @delowardev! I'll close this as an alternative approach was merged for this here: #37595