-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update layout toggle label #36675
Update layout toggle label #36675
Conversation
Size Change: +4 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
So to summarize the current text is "Inherit default layout". The proposed text is "Use inner block alignment". |
This setting is one of most confusing things we are shipping. I don't think a label alone can capture what it does properly. Can we look at expanding what it does in a help paragraph, at least when it's toggled on? |
There's some prior discussion and iteration on this label over in this issue: #31950 My initial explorations at the top were just simple re-labeling (including a paragraph explainer). But @jameskoster, @shaunandrews, and I expanded into more UI explorations later down the thread. |
Hi! Editorial here -- got the Needs Copy Review notification. I followed/read through the convo at #31950 but I'm not totally clear of the copy that needs to be reviewed — or if there's still discussion happening over this label and the text/descriptions. Personally, as a general user I attribute "layout" with theme/template/overall design; I also don't know what an "inner block" is, though that comment is coming from someone who's never used a group block before. Anyway, if you need our input on specific copy for polishing, just ping us/me again and I can try to help. Thanks! |
Regarding #31950 I don't think there is time for the UI changes, but we can still add a help text? "Blocks placed inside |
I find this control so confusing 🙈 One of the elements I struggle with most is that I have no context for "default". It's not clear:
This is compounded by the fact that it's not obvious (to me at least) that these width settings are applied to the blocks inside this one. A quick sketch that might help: I've replaced references to "default" with "theme", which hopefully clarifies that the values – if not customised – come from the active theme. I used a segmented control but if more words are needed a toggle or even radios could work instead. When theme values are used the inputs remain visible, but disabled. This way you can at least see what those values are and loosely interpret how they might manifest on the canvas. |
I proposed the string change only, for now, short term, because the 5.9 string freeze happens at 20:00 UTC today. |
Can this be closed considering the recent changes in this PR? #41893 |
Description
As originally brought up here, I wanted to iterate on the label we're currently using for the layout control's "Inherit default layout". The current label of "Inherit default layout" does not provide enough context to what's actually happening when that control is enabled.
When active, the blocks within the Group block have their own alignment controls available (essentially how Group blocks functioned before introducing this control).
When inactive, the user cannot set wide/full width alignments for those child blocks.
I don't know that I'm sold on the label I'm suggesting entirely, but does anyone else have another idea that could work better?
Screenshots
Previous:
This PR:
Types of changes
Copy change
Checklist: