-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Rename user preset origin to custom #36748
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
labels
Nov 22, 2021
jorgefilipecosta
requested review from
ellatrix,
oandregal,
spacedmonkey and
TimothyBJacobs
as code owners
November 22, 2021 19:15
jorgefilipecosta
force-pushed
the
update/rename-user-preset-origin-to-custom
branch
from
November 22, 2021 19:18
001c981
to
789d0de
Compare
Size Change: +306 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
oandregal
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works fine, although I've run into a bug that will be fixed by #36747
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Nov 28, 2021
noisysocks
pushed a commit
that referenced
this pull request
Nov 29, 2021
* Update: Rename user preset origin to custom * Fix PHP tests * Fix JS tests * Remove console.log Co-authored-by: André <583546+oandregal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows a suggestion by @oandregal and renames the user preset origin to custom.
Similar to #36645 that renamed core to default.
How has this been tested?
I opened the site editor and verified a user can still change all three color palette origins.