Highlight "Site" in the navigation panel #36762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
38 tasks
|
Size Change: +17 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Looks good!
The active link could also have aria-current set (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-current). What do you think?
I'll add this as a suggestion to the tracking issue |
Oh yep! Good point! I thought I added it before but turns out it's in another branch 😅 . |
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 29, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #36597.
Highlight the "Site" link when using the editor. Currently every page other than the list pages are considered to be inside the editor so I just highlight the link in all of them. Not sure if it's desirable though.
How has this been tested?
tt1-blocksthemeScreenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).