Fix template part slug generation when creating through the block placeholder #36764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: +7 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
Mamaduka
deleted the
fix/template-part-slug-when-creating-from-placeholder
branch
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In most cases where a template part is created, the slug is generated by using the
kebabCasefunction on the title:gutenberg/packages/edit-site/src/components/add-new-template/new-template-part.js
Line 31 in e2f00ff
gutenberg/packages/edit-site/src/components/template-part-converter/convert-to-template-part.js
Line 37 in e2f00ff
But when a template part is created by inserting a template part block and following the steps in the block placeholder, the template part slug is incorrectly hard-coded, which will lead to some non-descriptive slugs:
gutenberg/packages/block-library/src/template-part/edit/placeholder/index.js
Line 68 in e2f00ff
This PR fixes that to also
kebabCasethe title.How has this been tested?
wp.data.select( 'core' ).getEntityRecords( 'postType', 'wp_template_part', { per_page: -1 } )in the console, find the template part you created and check out its slug (and approve the PR).Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).