Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolsPanel: Prevent tools panel menu increasing empty panel height #36895

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

aaronrobertshaw
Copy link
Contributor

Description

This PR tweaks the ToolsPanel so that an empty panel's height is consistent with a collapsed panel.

This issue was raised through the review process of switch the border panel over to use the ToolsPanel.

See: #33743 (comment)

How has this been tested?

  1. Via the Storybook and inspecting the empty panel's height is 49px
  2. Cherry-picking this change onto the Border panel switch to ToolsPanel PR
    • Open block editor, add group block, and select it.
    • Confirm the collapsed color panel's height is the same as the empty border panel's.

Screenshots

Screen Shot 2021-11-26 at 3 07 11 pm

Screen Shot 2021-11-26 at 3 08 58 pm

Types of changes

Enhancement.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@aaronrobertshaw aaronrobertshaw added [Feature] UI Components Impacts or related to the UI component system CSS Styling Related to editor and front end styles, CSS-specific issues. labels Nov 26, 2021
@aaronrobertshaw aaronrobertshaw self-assigned this Nov 26, 2021
@aaronrobertshaw aaronrobertshaw changed the title Prevent tools panel menu increase empty panel height ToolsPanel: Prevent tools panel menu increasing empty panel height Nov 26, 2021
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aaronrobertshaw ! Could you add a little CHANGELOG entry before merging?

Otherwise LGTM 🚀

@aaronrobertshaw aaronrobertshaw force-pushed the fix/tools-panel-header-height branch 2 times, most recently from d5dfe25 to 3b7be31 Compare November 29, 2021 05:49
@aaronrobertshaw aaronrobertshaw force-pushed the fix/tools-panel-header-height branch from 3b7be31 to d3e8f87 Compare December 1, 2021 02:15
@aaronrobertshaw aaronrobertshaw merged commit 64a21e5 into trunk Dec 1, 2021
@aaronrobertshaw aaronrobertshaw deleted the fix/tools-panel-header-height branch December 1, 2021 05:39
@github-actions github-actions bot added this to the Gutenberg 12.1 milestone Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] UI Components Impacts or related to the UI component system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants