-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add origin and author to template rest api #36896
Conversation
Can we update the schema tests to ensure these new properties are found in the REST API. |
ee7788e
to
772f8c8
Compare
I had a look into this, but it doesn't seem possible right now because the Gutenberg version of the REST API uses some code from WordPress core, which doesn't contain the necessary changes just yet. Some examples:
I don't think the way it's working in the plugin is quite right, I already noticed that the Gutenberg version of the REST API is still active when running 5.9 as an example - #36898. I'll follow up to fix these things. |
772f8c8
to
33f0890
Compare
Looks like I did need to update the tests. I don't think it's possible to test author support fully though until |
* Replicate API changes for template author support from WP core * WIP - origin * Use core version of template and template part post types and REST endpoints * Change post_author to author * Add translation domains * Replicate more core changes in gutenberg * Use gutenberg version of REST API * Update tests
Description
This replicates the changes to the core REST API proposed by WordPress/wordpress-develop#1937 for Gutenberg.
related UI changes - #36763