-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation: Enable even more compact setup state. #37089
Conversation
Size Change: +93 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
721ba4d
to
10a7f3f
Compare
Thanks for the review. Based on your screenshot I thought I knew what the problem was (overflow) — but as it turns out, I can't reproduce. I'm seeing the blobs cropped (which is its own problem) but doesn't bleed out like you show. Are there additional steps to reproduce? Which theme did you use? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the green check, I think it's important to land this one! The blobs being cut off is a failing of that concept, and I think we should remove them (#36858), but that likely won't make it to 5.9 at this point. |
Description
Fixes #37077.
This PR enables an even more compact setup state for when the block is used in very very narrow contexts. Shown in this GIF, a navigation block inside a 50% width column showing fewer buttons than the one outside:
Note that the code is a not as nice as it could be if we landed #36775. #36778 is also what I consider to be a more long term solution that both avoids layout shifts when selected, but also indicates the block could be used in a more preconfigured state.
How has this been tested?
Insert a navigation block in a thin column, and outside. Select it.
Checklist:
*.native.js
files for terms that need renaming or removal).